Bug 694733 - [RFE] change /distribution/reservesys (shorter default reserve time and warnings before return)
Summary: [RFE] change /distribution/reservesys (shorter default reserve time and warni...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Beaker
Classification: Retired
Component: scheduler
Version: 0.7
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: future_maint
Assignee: Bill Peck
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-04-08 07:38 UTC by Juraj Marko
Modified: 2015-09-01 03:38 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-09-28 01:29:15 UTC
Embargoed:


Attachments (Terms of Use)

Description Juraj Marko 2011-04-08 07:38:16 UTC
Description of problem:
Current reservesys reserve machines for 24 hours, but nobody is working 24 hours a day, and many times me and many other people forgot to return the machines to inventory. Is it possible to change the reservesys so the it reserve the machines only for 8 or 10 hours? And 1 hour before returning the machine to the inventory send a warning mail and irc message to owner? So everybody can run extendtestime.sh if is is necessary. I think this change can do de machines more available.

Comment 1 Petr Šplíchal 2011-04-08 10:11:10 UTC
+1, using a shorter default could help here.

Comment 2 David Kutálek 2011-04-11 06:40:41 UTC
What about weekends? Sometimes it happens your reservesys is waiting day or two in queue and then - machine is reserved and returned during weekend!

We can 1) reserve system at least till Monday noon, or 2) do not reserve during weekend at all. But because someone some time would like to work through weekend, option 2) should be optional ;-).

Comment 3 Juraj Marko 2011-04-11 07:09:55 UTC
May be the reservesys should have a check, if it is more then 16:00 Friday in country from which is owner of the machine, and set the test time minimal until 10:00 monday.

Comment 4 David Kutálek 2011-04-11 07:24:31 UTC
That sounds reasonable since this does not happen so often and workload during weekend is smaller. +1

(In reply to comment #3)
> May be the reservesys should have a check, if it is more then 16:00 Friday in
> country from which is owner of the machine, and set the test time minimal until
> 10:00 monday.

Comment 5 Petr Šplíchal 2011-04-11 08:14:47 UTC
(In reply to comment #2)
> What about weekends? Sometimes it happens your reservesys is
> waiting day or two in queue and then - machine is reserved and
> returned during weekend!

IMHO, you should not leave hanging reservesys jobs during the
weekend -- of course, unless you expect to also work during the
weekend :-)

I believe that if we keep a reasonable etiquette and some of the
discussed RFE's hit the production, those "waiting for day or two"
situations will not happen that often.

Comment 6 David Kovalsky 2011-04-11 10:37:46 UTC
Hi guys, 

a couple of thoughts:

 - shorter default reservation times - I partly agree. Though this has to be combined with "blackout times" (see below) to be useful. If the default reservation time is 8h, then if the system lands at 20:00 when you're not working anymore it will timeout before you come to work. Starting with 16h and seeing if that helps and doesn't cause more problems could make it easier to swallow. 

 - e-mail one hour before returning - too small/tricky. One hour is just the time around lunch/meeting. And I believe we should not be sitting on email all of the time. And we all get lots of emails ... I would shoot for at least 2 hours and make the notification opt-in. Otherwise it will be yet-another-filtered-email that oneone reads (too many emails) or reads late.

IRC notifications - we don't have a IRC roster, which would map user <--> IRC nick (and not to mention _afk, _wfh, ...). We could add the info to LDAP, though I believe this would be more work alltogether then this would bring. 
Perhaps an opt-in (notify nick regexp ^dkovalsk.* @ #brno). Starting to sound complicated ... 


 - reservation & weekends - that's tricky. This has been discussed in the past, see bug 503705 (RFE: do not count weekends to reservation time).

Calculating timezones is extra work, still you're missing holidays for example (which are very different in every country). You're also blocking the machine for 3 days effectively and people in different timezone will be out of luck (Ex: China - +6h from Brno, +12 hours from Westford). We also have people who work on weekends (GSS coverage for example), not sure how big role they play with Beaker ATM.

My opinion is that this would just turn one problem into another. 

How about implementing some "blackouts" for this case? Not perfect, hopefully it will trigger someone else's thought who can make it better :)

Example: 
 - I want system foo.redhat.com, but at latest Friday 14:00 UTC and at earliest Mon 8:00 UTC. Otherwise skip to the next person and keep me in the queue (saves a wasted reinstall/blocked time). 

 - I want foo.redhat.com, but if it's later then April 1st then I don't want it anymore. 



I don't have a patent for The Ultimate Truth, take this as thoughts to consider when drawing a solution.

Comment 7 Juraj Marko 2011-04-11 11:02:27 UTC
May be this could be a part of preferences in beaker, now you can set up there only a email address, but bay be it will be nice to set up a time before returning in which you should become a warning email. And it will be nice to set up a times in which you will not become any reservations. So your unsatisfied reservations will wait you until morning or until monday and only in that time your reservation will be done so you don't block any machines when you are not in work.

Comment 8 Bill Peck 2011-04-11 12:55:01 UTC
I don't want crazy reserve sys logic in the scheduler.  The scheduler shouldn't care about a particular task.

The place for this change would be in the workflow command that you run.  After all, you know what time zone you are in.

We use to have a reserve workflow.  I'd be happy bringing that back as a bkr command.

Comment 9 Bill Peck 2011-09-15 18:54:34 UTC
Any consensus on this?  I didn't get an answer about the specific reserve workflow

Comment 10 Ales Zelinka 2011-09-16 09:58:38 UTC
This should be implemented in /distribution/reservesys and made the defualt, otherwise it won't work well (IMHO).:

 - Scheduling /distribution/reservesys became equivalent to reserving a machine. Even if reservesys workflow gets resurrected, folks will probably continue using /dist/resys with 24hour lease time. 

 - This RFE only make sense if made the default, used by majority. IMHO those who would willingly chose to use it are those who are aware of the machine shortage and watch their reservation times already.

Comment 11 Dan Callaghan 2012-09-28 01:29:15 UTC
There is little point changing the default reservesys time because most people already specify longer than 24 hours anyway. And it's not practical for Beaker to keep track of every user's working hours, weekends, and public holidays and then pass that information down to the reservesys task.


Note You need to log in before you can comment on or make changes to this bug.