Spec URL: http://rrati.fedorapeople.org/wso2-wsf-cpp.spec SRPM URL: http://rrati.fedorapeople.org/wso2-wsf-cpp-2.1.0-0.8.fc14.src.rpm Description: WSO2 WSF/C++ is a standards compliant, enterprise grade, open source, C++ library for providing and consuming Web services in C++. WSO2 WSF/C++ is a complete solution for building and deploying Web services, and is the C++ library with a wide range of WS-* specification implementations, including MTOM, WS-Addressing, WS-Policy, WS-Security, WS-SecurityPolicy, WS-Reliable Messaging and WS-eventing The WSO2 distribution contains versions of these additional projects: Apache Axis2/C: http://axis.apache.org/axis2/c/core/ Apache Rampart/C: http://axis.apache.org/axis2/c/rampart/ Apache Sandesha2/C: http://axis.apache.org/axis2/c/sandesha/ Apache Savan/C: http://ws.apache.org/savan/c/ The spec creates separate sub-packages for these projects, but they are not independent.
Created attachment 491546 [details] License file information Performed after "make local" on F13 of 2.1.0-0.3 Visually inspected first 50 lines of all .cpp, .c, .h, .java, .wsdl, and .xsd files (2,118 files) Questionable files are attached, Stamped with Apache Software License and Gilles Vollant copyright ./wsf_c/axis2c/util/src/minizip/axis2_iowin32.h ./wsf_c/axis2c/util/src/minizip/axis2_ioapi.h ./wsf_c/axis2c/util/src/minizip/axis2_unzip.h ./wsf_c/axis2c/util/src/minizip/axis2_crypt.h ./wsf_c/axis2c/util/src/minizip/unzip.c ./wsf_c/axis2c/util/src/minizip/ioapi.c ./wsf_c/axis2c/util/src/minizip/crypt.c ./wsf_c/axis2c/util/src/minizip/iowin32.c Licensed with a blessing - ./wsf_c/sandesha2c/src/storage/sqlite/sqlite3.h ./wsf_c/savanc/include/sqlite3.h ./wsf_c/sandesha2c/src/storage/sqlite/sqlite3.c ./wsf_c/savanc/src/subs_mgrs/sqlite/sqlite3.c b51144abf1d352eec99fdb9eca65f59a ./wsf_c/sandesha2c/src/storage/sqlite/sqlite3.h b51144abf1d352eec99fdb9eca65f59a ./wsf_c/savanc/include/sqlite3.h ba160c2f8009fc67bb4c89795d5bc8f6 ./wsf_c/sandesha2c/src/storage/sqlite/sqlite3.c 8df9f0f3fa1119201d1a2b7e3e385ff1 ./wsf_c/savanc/src/subs_mgrs/sqlite/sqlite3.c C++: 93 source files (find -name "*.cpp") 43 are auto-generated from WSDL by Apache Axis2/C 7 with no license at all - ./examples/trader/trader/trader-client/TraderClientMacro.cpp ./examples/trader/trader/trader-util/SimpleTrader.cpp ./examples/trader/client/traderclient.cpp ./examples/trader/util/ClientData.cpp ./examples/trader/exchange/SimpleExchange.cpp ./examples/trader/exchange/ExchangeTraderMacro.cpp ./examples/codegen/stockquote/client/main.cpp C: 863 source files (find -name "*.c") 786 are Apache Software Licensed 4 have Apache Software License and Gilles Vollant copyright ./wsf_c/axis2c/util/src/minizip/unzip.c ./wsf_c/axis2c/util/src/minizip/ioapi.c ./wsf_c/axis2c/util/src/minizip/crypt.c ./wsf_c/axis2c/util/src/minizip/iowin32.c 46 are auto-generated from WSDL by Apache Axis2/C 2 are a blessing - ./wsf_c/sandesha2c/src/storage/sqlite/sqlite3.c ./wsf_c/savanc/src/subs_mgrs/sqlite/sqlite3.c 25 with no license at all - ./wsf_c/axis2c/test/core/clientapi/test_svc_client_handler_count.c ./wsf_c/axis2c/neethi/test/test.c ./wsf_c/axis2c/axiom/test/util/axiom_util_test.c ./wsf_c/axis2c/guththila/tests/test.c ./wsf_c/axis2c/guththila/tests/test_attribute.c ./wsf_c/axis2c/util/src/stomp/frame.c ./wsf_c/axis2c/util/src/stomp/main.c ./wsf_c/axis2c/util/src/stomp/stomp.c ./wsf_c/axis2c/util/test/date_time/date_time_test.c ./wsf_c/axis2c/util/test/link_list/link_list_test.c ./wsf_c/axis2c/util/test/duration/duration_test.c ./wsf_c/axis2c/util/test/rand/rand_test.c ./wsf_c/axis2c/util/test/uri/uri_test.c ./wsf_c/axis2c/util/test/stack/stack_test.c ./wsf_c/axis2c/util/test/string_util/string_util_test.c ./wsf_c/axis2c/util/test/util/create_env.c ./wsf_c/axis2c/util/test/url/url_test.c ./wsf_c/axis2c/util/test/allocator/allocator_test.c ./wsf_c/axis2c/util/test/properties/property_test.c ./wsf_c/axis2c/util/test/utils/utils_test.c ./wsf_c/axis2c/samples/wso2-wsf-c-src-2.0.0/codegen/databinding/Calculator/client/CalculatorAdd.c ./wsf_c/axis2c/samples/codegen/databinding/Calculator/client/CalculatorAdd.c ./wsf_c/rampartc/test/util/test_sha.c ./wsf_c/rampartc/test/util/test_util.c ./wsf_c/rampartc/samples/client/sts_client/client.c H: 727 header files (find -name "*.h") 621 are Apache Software Licensed 4 have Apache Software License and Gilles Vollant copyright ./wsf_c/axis2c/util/src/minizip/axis2_iowin32.h ./wsf_c/axis2c/util/src/minizip/axis2_ioapi.h ./wsf_c/axis2c/util/src/minizip/axis2_unzip.h ./wsf_c/axis2c/util/src/minizip/axis2_crypt.h 74 are auto-generated from WSDL by Apache Axis2/C 2 are a blessing - ./wsf_c/sandesha2c/src/storage/sqlite/sqlite3.h ./wsf_c/savanc/include/sqlite3.h 26 with no license at all - ./examples/trader/trader/trader-util/SimpleTrader.h ./examples/trader/include/ClientData.h ./examples/trader/exchange/SimpleExchange.h ./config.h ./wsf_c/examples/config.h ./wsf_c/config.h ./wsf_c/wsclient/config.h ./wsf_c/sandesha2c/config.h ./wsf_c/axis2c/config.h ./wsf_c/axis2c/neethi/config.h ./wsf_c/axis2c/tools/tcpmon/config.h ./wsf_c/axis2c/tools/tcpmon/src/tcpmon_session_local.h ./wsf_c/axis2c/tools/tcpmon/src/tcpmon_entry_local.h ./wsf_c/axis2c/tools/tcpmon/test/unit/tcpmon_test.h ./wsf_c/axis2c/axiom/config.h ./wsf_c/axis2c/guththila/tests/test.h ./wsf_c/axis2c/guththila/config.h ./wsf_c/axis2c/util/config.h ./wsf_c/axis2c/util/src/stomp/axutil_stomp_frame.h ./wsf_c/axis2c/util/src/stomp/axutil_stomp.h ./wsf_c/axis2c/util/test/util/create_env.h ./wsf_c/axis2c/util/include/axutil_stomp_frame.h ./wsf_c/axis2c/util/include/axutil_stomp.h ./wsf_c/savanc/config.h ./wsf_c/savanc/samples/config.h ./wsf_c/rampartc/config.h Java: 226 Java files (find -name "*.java") 221 are Apache Software Licensed 5 with no license at all ./wsf_c/build/codegen/modules/org.wso2.wsf.codegen/src/org/wso2/wsf/codegen/Activator.java ./wsf_c/build/codegen/modules/adb-codegen/test/org/apache/axis2/schema/populate/Util.java ./wsf_c/build/codegen/modules/codegen/src/org/apache/axis2/wsdl/databinding/CPPDefaultTypeMapper.java ./wsf_c/build/codegen/modules/codegen/src/org/apache/axis2/wsdl/databinding/CPPTypeMapper.java ./wsf_c/build/codegen/modules/codegen/src/org/apache/axis2/wsdl/WSDL2CPP.java WSDL: 143 WSDL files (find -name "*.wsdl") 63 are Apache Software Licensed 80 with no license at all - see wsdl-no-apache XSD: 66 XSD files (find -name "*.xsd") 63 are Apache Software Licensed 3 with no license at all ./wsf_c/axis2c/axiom/test/resources/wsdl/nillableComplexType.xsd ./wsf_c/axis2c/samples/wso2-wsf-c-src-2.0.0/codegen/databinding/StockQuoteService/StockQuote.xsd ./wsf_c/axis2c/samples/codegen/databinding/StockQuoteService/StockQuote.xsd cpp-no-apache ./examples/trader/trader/trader-client/TraderClient.cpp ./examples/trader/trader/trader-client/TraderClientMacro.cpp ./examples/trader/trader/trader-client/TraderClientSkeleton.cpp ./examples/trader/trader/trader-util/ExchangeTraderStub.cpp ./examples/trader/trader/trader-util/SimpleTrader.cpp ./examples/trader/client/traderclient.cpp ./examples/trader/client/TraderClientStub.cpp ./examples/trader/util/LoginRequest.cpp ./examples/trader/util/BuyRequest_ex.cpp ./examples/trader/util/RegisterClientResponse.cpp ./examples/trader/util/DepositRequest.cpp ./examples/trader/util/ClientData.cpp ./examples/trader/util/DepositResponse.cpp ./examples/trader/util/GetSymbolsRequest.cpp ./examples/trader/util/GetQuoteRequest.cpp ./examples/trader/util/ClientInfo.cpp ./examples/trader/util/GetQuoteResponse.cpp ./examples/trader/util/StockQuote.cpp ./examples/trader/util/PortFolioItem.cpp ./examples/trader/util/SellRequest_ex.cpp ./examples/trader/util/GetPortfolioResponse.cpp ./examples/trader/util/RegisterFeedTargetRequest.cpp ./examples/trader/util/BuyResponse.cpp ./examples/trader/util/SellResponse.cpp ./examples/trader/util/CreateAccountResponse.cpp ./examples/trader/util/CreateAccountRequest.cpp ./examples/trader/util/BuyRequest.cpp ./examples/trader/util/ArrayOfString.cpp ./examples/trader/util/TradeStatus.cpp ./examples/trader/util/RegisterClientRequest.cpp ./examples/trader/util/SellRequest.cpp ./examples/trader/util/GetPortfolioRequest.cpp ./examples/trader/util/GetSymbolsResponse.cpp ./examples/trader/util/PortFolio.cpp ./examples/trader/exchange/SimpleExchange.cpp ./examples/trader/exchange/ExchangeTraderSkeleton.cpp ./examples/trader/exchange/ExchangeTraderMacro.cpp ./examples/trader/exchange/ExchangeTrader.cpp ./examples/codegen/calculator-xml-inout/service/CalculatorSkeleton.cpp ./examples/codegen/stockquote/service/SimpleStockQuoteServiceSkeleton.cpp ./examples/codegen/stockquote/client/main.cpp ./examples/codegen/calculator/service/CalculatorSkeleton.cpp ./examples/codegen/calculator/service/wrapped/CalculatorSkeleton.cpp
Note: Compilation succeeds even after rm -rf wsf_c/axis2c/util/src/minizip
Other than the possible licensing issues found above, I don't see anything wrong with the package. rpmlint output: $ rpmlint wso2-wsf-cpp-2.1.0-0.8.fc14.src.rpm wso2-wsf-cpp.src: W: invalid-url Source0: wso2-wsf-cpp-src-2.1.0.tar.gz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. I presume that will be fixed once it goes into Fedora build system. I will wait until Matts comments are addressed before acking.
sqlite is public domain and concatenating the source/header files is common. No issues there. The minizip files look to be based off of minizip (http://www.winimage.com/zLibDll/minizip.html) version 1.01e. There are differences (white spacing, re-arranging), but the code is basically the same as the 1.01e distribution
I haven't looked closely at the package, but keep in mind that Fedora has a policy against bundling libraries: http://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries This includes sqlite and minizip.
New package: http://rrati.fedorapeople.org/wso2-wsf-cpp-2.1.0-1.fc14.src.rpm Changes include: - Redo of the apache2 modules, only 1 needed/created - Removed the minizip and sqlite source code from the upstream tarball
Looks good to me. APPROVED.
New Package SCM Request ======================= Package Name: wso2-wsf-cpp Short Description: WSO2 Web Services Framework for C++ Owners: rrati Branches: InitialCC: matt
This ticket is not assigned to anyone. It should be assigned to the reviewer. Please fix and re-raise the fedora-cvs flag.
Git done (by process-git-requests).
Package Change Request ====================== Package Name: wso2-wsf-cpp New Branches: f15 Owners: rrati InitialCC: matt I'd like to get this package into F15 also.