Spec URL: http://mmahut.fedorapeople.org/reviews/python-rhev/python-rhev.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/python-rhev/python-rhev-0.9-1.el6.20110316git.src.rpm Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2999006 Description: Python-RHEV is a Python binding to Red Hat Enterprise Virtualization's REST API. Object oriented. Up to Date. Validating.
Taking it for a ride^Wreview!
* Version number correct * Builds fine in mock * Filelist sane * Requires/provides sane * SPEC file, clean and legible 0.) Not named correctly The source package should be named rhevm-api; you should use %package -n python-rhev to make a python-rhev subpackage. The rationale behind that is that the (source) package name should correspond to upstream project name. Also, it looks like there are java (and other languages) sources in the tree, this would make it easier and more consistent to package them up if someone wishes to. 1.) Revision number not correct IS: 1%{?dist}.20110316git SHOULD BE: 1.20110316git%{?dist} 2.) License tag not correct This is mess and should be fixed upstream: LICENSE file is LGPLv2, while python files referring to it are MIT: # This file is part of python-rhev. python-rhev is free software that is # made available under the MIT license. Consult the file "LICENSE" that # is distributed together with this file for the exact licensing terms. Apparently, there are LGPLv2-ed files there as well though. 3.) python-rhev-0.9-fix-dependencies.patch Should be submitted upstream. 4.) The description sounds weird: Python-RHEV is a Python binding to Red Hat Enterprise Virtualization's REST API. Object oriented. Up to Date. Validating. Maybe using full sentences would make more sense? Python-RHEV is a validating object-oriented Python binding to Red Hat Enterprise Virtualization's REST API.
You may also want to package the rhevmsh; it's python as well, should be easy to package up.
0) I'm in contact with the upsteam and they are planning to split the tarball. The git tree and the tarball contains other pieces of softwere I'm planing submitting for separate review (rhevsh for example) - these are separate packages and should be in separate spec files. 1) Fixed. 2) Confirmed w/ upstream - it's MIT. 3) It is - I'm in active communication w/ upstream. 4) I agree.
(In reply to comment #3) > You may also want to package the rhevmsh; it's python as well, should be easy > to package up. I'm working on it :) will be submitted soon http://mmahut.fedorapeople.org/reviews/rhevsh/
The new python-rhev package is located at http://mmahut.fedorapeople.org/reviews/python-rhev/python-rhev-0.9-1.20110316git.fc12.src.rpm
* License tag correct * license text included * Revision number corrected And finally the comments are a good excuse for the package's name. APPROVED
New Package SCM Request ======================= Package Name: python-rhev Short Description: Python binding to Red Hat Enterprise Virtualization's REST API Owners: mmahut Branches: f14 f15 el6 el5
Git done (by process-git-requests).
Build - thank you for the branch and the review.