Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Created attachment 492018[details]
Patch that addresses this issue
Description of problem:
An ASN1_STRING function uses a variable that has not been initialised
Version-Release number of selected component (if applicable):
openssl-1.0.0-4.el6_0.2.x86_64
How reproducible:
Run under valgrind a simple application that establishes an ssl connection
Steps to Reproduce:
1. build attached c++ sample app (requires boost c++ libraries):
g++ ssltest.cpp -o ssltest -lboost_system-mt -lssl
2. run under valgrind, (needs certificate authority of server in a file located in current dir at ca.pem)
valgrind ./ssltest $ip $port
Actual results:
Conditional jump or move depends on uninitialised value(s)
at 0x60A1B7C: ASN1_STRING_set (in /usr/lib64/libcrypto.so.1.0.0)
by 0x608F73C: ASN1_mbstring_ncopy (in /usr/lib64/libcrypto.so.1.0.0)
by 0x608F933: ASN1_mbstring_copy (in /usr/lib64/libcrypto.so.1.0.0)
by 0x608FAE0: ASN1_STRING_to_UTF8 (in /usr/lib64/libcrypto.so.1.0.0)
by 0x6091C5F: ??? (in /usr/lib64/libcrypto.so.1.0.0)
by 0x60921B6: ??? (in /usr/lib64/libcrypto.so.1.0.0)
by 0x6098782: ASN1_item_ex_d2i (in /usr/lib64/libcrypto.so.1.0.0)
by 0x6099298: ??? (in /usr/lib64/libcrypto.so.1.0.0)
by 0x609959B: ??? (in /usr/lib64/libcrypto.so.1.0.0)
by 0x6098CC9: ASN1_item_ex_d2i (in /usr/lib64/libcrypto.so.1.0.0)
by 0x6099298: ??? (in /usr/lib64/libcrypto.so.1.0.0)
by 0x609959B: ??? (in /usr/lib64/libcrypto.so.1.0.0)
Amongst other errors if openssl was not built with -DPURIFY, and some leaks due to the ASIO ssl implementation
Expected results:
With openssl built with -DPURIFY option, and attached patch, no use of uninitialised variables, although ASIO issues remain.
Additional info:
The offending line is: openssl-1.0.0/crypto/asn1/asn1_lib.c:382 (ASN1_STRING_set)
The object at the root of the problem is a stack based instance of
ASN1_STRING at: openssl-1.0.0/crypto/asn1/a_strex.c:554 (ASN1_STRING_to_UTF8)
In my patch, I fix the issue by initialising the length field of the stack based object in ASN1_STRING_to_UTF8, immediately after the existing initialisation of the corresponding data field.
This issue is a pure code cleanness problem. If you look at the condition where the uninitialized memory is read you can see that as the str->data is initialized to NULL. The condition always succeeds in this case regardless of the contents of the uninitialized str->length.
Created attachment 492018 [details] Patch that addresses this issue Description of problem: An ASN1_STRING function uses a variable that has not been initialised Version-Release number of selected component (if applicable): openssl-1.0.0-4.el6_0.2.x86_64 How reproducible: Run under valgrind a simple application that establishes an ssl connection Steps to Reproduce: 1. build attached c++ sample app (requires boost c++ libraries): g++ ssltest.cpp -o ssltest -lboost_system-mt -lssl 2. run under valgrind, (needs certificate authority of server in a file located in current dir at ca.pem) valgrind ./ssltest $ip $port Actual results: Conditional jump or move depends on uninitialised value(s) at 0x60A1B7C: ASN1_STRING_set (in /usr/lib64/libcrypto.so.1.0.0) by 0x608F73C: ASN1_mbstring_ncopy (in /usr/lib64/libcrypto.so.1.0.0) by 0x608F933: ASN1_mbstring_copy (in /usr/lib64/libcrypto.so.1.0.0) by 0x608FAE0: ASN1_STRING_to_UTF8 (in /usr/lib64/libcrypto.so.1.0.0) by 0x6091C5F: ??? (in /usr/lib64/libcrypto.so.1.0.0) by 0x60921B6: ??? (in /usr/lib64/libcrypto.so.1.0.0) by 0x6098782: ASN1_item_ex_d2i (in /usr/lib64/libcrypto.so.1.0.0) by 0x6099298: ??? (in /usr/lib64/libcrypto.so.1.0.0) by 0x609959B: ??? (in /usr/lib64/libcrypto.so.1.0.0) by 0x6098CC9: ASN1_item_ex_d2i (in /usr/lib64/libcrypto.so.1.0.0) by 0x6099298: ??? (in /usr/lib64/libcrypto.so.1.0.0) by 0x609959B: ??? (in /usr/lib64/libcrypto.so.1.0.0) Amongst other errors if openssl was not built with -DPURIFY, and some leaks due to the ASIO ssl implementation Expected results: With openssl built with -DPURIFY option, and attached patch, no use of uninitialised variables, although ASIO issues remain. Additional info: The offending line is: openssl-1.0.0/crypto/asn1/asn1_lib.c:382 (ASN1_STRING_set) The object at the root of the problem is a stack based instance of ASN1_STRING at: openssl-1.0.0/crypto/asn1/a_strex.c:554 (ASN1_STRING_to_UTF8) In my patch, I fix the issue by initialising the length field of the stack based object in ASN1_STRING_to_UTF8, immediately after the existing initialisation of the corresponding data field.