Red Hat Bugzilla – Bug 696697
Don't allow negative limit value to be set [RFE]
Last modified: 2012-03-15 07:50:37 EDT
Description of problem: Cumin curently allows negative limit values. Condor apparently allows it as well, but this is nonsensical. Limit values should have a floor of 0. Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: 1. Run a job with a concurrency_limit value 2. Use cumin to dynamically set the limit to a negative number Actual results: The limit is changed. Expected results: Cumin should change the value to 0 before submitting the change. Additional info:
Revision 4774.
Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: Cause The UI allows negative max allowance values to be entered when editing a limit under the "Limits" tab. Consequence The system accepts the negative value and displays a negative max allowance for the limit. Practically, the system behaves as if the max allowance is 0. However, displaying a negative value on the screen may cause confusion. Fix Negative max allowance values are set to 0 before they are submitted. Result When the "Limits" screen updates, the max allowance value will be shown as 0 if a negative max allowance value was entered.
Add some form validation for this too.
Revision 4799, error dialog added.
Technical note updated. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -5,7 +5,7 @@ The system accepts the negative value and displays a negative max allowance for the limit. Practically, the system behaves as if the max allowance is 0. However, displaying a negative value on the screen may cause confusion. Fix - Negative max allowance values are set to 0 before they are submitted. + Limit value is validated and is not allowed to be zero. Result - When the "Limits" screen updates, the max allowance value will be shown as 0 if a negative max allowance value was entered.+ User is presented with a standard cumin form error dialog if a negative limit is entered and no change is made to the limit.
Message when I try to set negative limit: The 'Max Allowance' field may not be less than zero Verified in cumin-0.1.4840-1.el5
Technical note updated. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1,11 +1 @@ -Cause +The user interface allowed negative maximum allowance values to be entered when editing a limit under the "Limits" tab. Although the system accepted the negative value and displayed it in the user interface, internally it treated the value as if it were 0 (zero). This update changes this behavior so that entering a negative maximum allowance value causes Cumin to display an error message, and internally the limit is not changed.- The UI allows negative max allowance values to be entered when editing a limit under the "Limits" tab. - -Consequence - The system accepts the negative value and displays a negative max allowance for the limit. Practically, the system behaves as if the max allowance is 0. However, displaying a negative value on the screen may cause confusion. - -Fix - Limit value is validated and is not allowed to be zero. - -Result - User is presented with a standard cumin form error dialog if a negative limit is entered and no change is made to the limit.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2011-1249.html