Hide Forgot
Created attachment 492814 [details] Patch file for RAID controller driver, arcmsr, at RHEL6 Update2 Description of problem: Patch file for RAID controller driver, arcmsr, at RHEL6 Update2
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release.
Nick, I hope I can post the update soon to the internal list. We need from you a commitment that you will test this update when we make the test release accessible for you. Thanks, Tomas
Tomas, Sure. If the release is available, please let me know. I will test it in no time.
Created attachment 504701 [details] Patch file for RAID controller driver, arcmsr, at RHEL6 Update2 This is the patch with a minor change - I removed a parenthesis pair to better fit upstream, further I removed the changes to arcmsr/.tmp_versions/arcmsr.mod file, Nick do you agree?
Hi Tomas, What a lot of changes! I can't tell which are from you. Could you make another patch? Thanks,
(In reply to comment #11) > Hi Tomas, > What a lot of changes! > I can't tell which are from you. > Could you make another patch? > Thanks, Nick, in fact the changes are really minor - I removed a pair of parenthesis and removed a file which I think you added by mistake. A good tool to compare patches is interdiff, so: > interdiff -p8 orig.patch new.patch diff -u arcmsr.1.20.00.15.el6u2-100805/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- arcmsr.1.20.00.15.el6u2-100805/arcmsr_hba.c 2011-04-18 15:07:51.000000000 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c @@ -1170,9 +1170,8 @@ arcmsr_cdb->msgPages = arccdbsize/0x100 + (arccdbsize % 0x100 ? 1 : 0); if ( arccdbsize > 256) arcmsr_cdb->Flags |= ARCMSR_CDB_FLAG_SGL_BSIZE; - if (pcmd->sc_data_direction == DMA_TO_DEVICE) { + if (pcmd->sc_data_direction == DMA_TO_DEVICE) arcmsr_cdb->Flags |= ARCMSR_CDB_FLAG_WRITE; - } ccb->arc_cdb_size = arccdbsize; return SUCCESS; } reverted: --- arcmsr.1.20.00.15.el6u2-100805/.tmp_versions/arcmsr.mod 2011-04-18 14:58:06.000000000 +0800 +++ arcmsr/.tmp_versions/arcmsr.mod 1970-01-01 08:00:00.000000000 +0800 @@ -1,2 +0,0 @@ -/root/arcmsr.1.20.00.15.el6u2-100805/arcmsr.ko -/root/arcmsr.1.20.00.15.el6u2-100805/arcmsr_hba.o /root/arcmsr.1.20.00.15.el6u2-100805/arcmsr_attr.o As you can see it isn't so much:) Please next time post your patches here in the same form as in upstream so use this depth "diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h" instead of "diff -Naurp arcmsr/arcmsr_attr.c arcmsr.1.20.00.15.el6u2-100805/arcmsr_attr.c" so it can be applied with "patch -p1 .." Thanks, Tomas
OK. I agree with it. Thank you, Tomas,
Posted to internal review.
Patch(es) available on kernel-2.6.32-184.el6
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2011-1530.html