Hide Forgot
Spec URL: http://pwu.fedorapeople.org/rubygem-file-tail/rubygem-file-tail.spec SRPM URL: http://pwu.fedorapeople.org/rubygem-file-tail/rubygem-file-tail-1.0.5-1.fc13.src.rpm Description: Library to tail files in Ruby
Suggestions: 1) Each Ruby package MUST indicate the Ruby ABI version it depends on. Add following at top lines %global rubyabi 1.8 2) missing BR BuildRequires: ruby(abi) = %{rubyabi} 3) License looks GPLv2 from README 4) For fedora we don't need buildroot,%clean section and cleaning of buildroot in %install
you can also add -doc subpackage %files doc %defattr(-, root, root, -) %{geminstdir}/examples %{geminstdir}/test %{geminstdir}/Rakefile %{gemdir}/doc/%{gemname}-%{version}
oops I just realized that its actually missing Requires and not BR: in above 2)
Here are new spec and rpm: Spec URL: http://pwu.fedorapeople.org/rubygem-file-tail/rubygem-file-tail.spec SRPM URL: http://pwu.fedorapeople.org/rubygem-file-tail/rubygem-file-tail-1.0.5-2.fc14.src.rpm Please review it.
Could you please execute the test suite during build?
Created attachment 493706 [details] modification to spec file to follow ruby guidelines - enable testsuite - Remove versions from versioned Requires. - Fix shebang to silent rpmlint warning. - Fix file permission issues.
oops enable following line in spec Requires: rubygem(spruz)
Thanks very much for the help. Here are the new spec and rpm: Spec URL: http://pwu.fedorapeople.org/rubygem-file-tail/rubygem-file-tail.spec SRPM URL: http://pwu.fedorapeople.org/rubygem-file-tail/rubygem-file-tail-1.0.5-3.fc14.src.rpm Please review it again.
Review: + koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3015380 + Upstream source verified as (sha1sum) 2b3bd0f0ae0419f670544064dc27f6286e0fc880 file-tail-1.0.5.gem 2b3bd0f0ae0419f670544064dc27f6286e0fc880 ../SOURCES/file-tail-1.0.5.gem + rpmlint gave rubygem-file-tail.noarch: W: no-manual-page-for-binary rtail rubygem-file-tail-doc.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings. APPROVED.
New Package SCM Request ======================= Package Name: rubygem-file-tail Short Description: File::Tail for Ruby Owners: pwu Branches: f15 f14 f13 el6 InitialCC: i18n-team petersen jamesni
Git done (by process-git-requests).
rubygem-file-tail-1.0.5-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-file-tail-1.0.5-3.fc14
rubygem-file-tail-1.0.5-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-file-tail-1.0.5-3.fc13
rubygem-file-tail-1.0.5-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/rubygem-file-tail-1.0.5-3.fc15
rubygem-file-tail-1.0.5-3.fc13 has been pushed to the Fedora 13 testing repository.
rubygem-file-tail-1.0.5-3.fc15 has been pushed to the Fedora 15 stable repository.
rubygem-file-tail-1.0.5-3.fc13 has been pushed to the Fedora 13 stable repository.
rubygem-file-tail-1.0.5-3.fc14 has been pushed to the Fedora 14 stable repository.