Spec URL: http://pwu.fedorapeople.org/rubygem-daemon_controller/rubygem-daemon_controller.spec SRPM URL: http://pwu.fedorapeople.org/rubygem-daemon_controller/rubygem-daemon_controller-0.2.5-1.fc13.src.rpm Description: A library for robust daemon management.
Suggestions: 1) Each Ruby package MUST indicate the Ruby ABI version it depends on. Add following at top lines %global rubyabi 1.8 2) missing BR BuildRequires: ruby(abi) = %{rubyabi} 3) License looks MIT 4) For fedora we don't need buildroot,%clean section and cleaning of buildroot in %install 5) Please provide direct download link for source to verify its checksum
oops I just realized that its actually missing Requires and not BR: in above 2)
Here are new spec and rpm: Spec URL: http://pwu.fedorapeople.org/rubygem-daemon_controller/rubygem-daemon_controller.spec SRPM URL: http://pwu.fedorapeople.org/rubygem-daemon_controller/rubygem-daemon_controller-0.2.5-2.fc14.src.rpm Please review it.
Could you please execute test suite during build?
Created attachment 493708 [details] Modification to spec to follow ruby guidelines - enable testsuite
Thanks very much for the help. Here are the new spec and rpm: Spec URL:http://pwu.fedorapeople.org/rubygem-daemon_controller/rubygem-daemon_controller.spec SRPM URL:http://pwu.fedorapeople.org/rubygem-daemon_controller/rubygem-daemon_controller-0.2.5-3.fc14.src.rpm Please review it again.
Review: + koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3015387 + Upstream source verified as (sha1sum) 929a9c6b62777eabff49cb83821bba4d43e1ea57 daemon_controller-0.2.5.gem 929a9c6b62777eabff49cb83821bba4d43e1ea57 ../SOURCES/daemon_controller-0.2.5.gem + rpmlint gave rubygem-daemon_controller-doc.noarch: W: no-documentation rubygem-daemon_controller-doc.noarch: E: zero-length /usr/lib/ruby/gems/1.8/gems/daemon_controller-0.2.5/spec/echo_server.pid.lock rubygem-daemon_controller-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/daemon_controller-0.2.5/ri/DaemonController/running%3f-i.yaml %3f 3 packages and 0 specfiles checked; 1 errors, 2 warnings. ==> I think its ok to have echo_server.pid.lock as zero-length file. Suggestions: 1) Looks I missed to add following to -doc instead of main package %{geminstdir}/*.gemspec APPROVED.
New Package SCM Request ======================= Package Name: rubygem-daemon_controller Short Description: A library for implementing daemon management capabilities Owners: pwu Branches: f15 f14 f13 el6 InitialCC: i18n-team petersen jamesni
Git done (by process-git-requests).
rubygem-daemon_controller-0.2.6-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-daemon_controller-0.2.6-1.fc14
rubygem-daemon_controller-0.2.6-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/rubygem-daemon_controller-0.2.6-1.fc15
rubygem-daemon_controller-0.2.6-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-daemon_controller-0.2.6-1.fc13
rubygem-daemon_controller-0.2.6-1.fc14 has been pushed to the Fedora 14 testing repository.
rubygem-daemon_controller-0.2.6-1.fc15 has been pushed to the Fedora 15 stable repository.
rubygem-daemon_controller-0.2.6-1.fc14 has been pushed to the Fedora 14 stable repository.
rubygem-daemon_controller-0.2.6-1.fc13 has been pushed to the Fedora 13 stable repository.
Is this package going to make it into EPEL6? It would be helpful.
rubygem-daemon_controller-0.2.6-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-daemon_controller-0.2.6-1.el6
rubygem-daemon_controller-0.2.6-1.el6 has been pushed to the Fedora EPEL 6 stable repository.