SPEC: http://people.redhat.com/varekova/libpipeline.spec SRPM: http://people.redhat.com/varekova/libpipeline-1.2.0-1.fc13.src.rpm Description: libpipeline is a C library for setting up and running pipelines of processes, without needing to involve shell command-line parsing which is often error-prone and insecure. This alleviates programmers of the need to laboriously construct pipelines using lower-level primitives such as fork(2) and execve(2)
I'll review it.
Listing MUST review items where I have comments, all others are OK. # MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.[1] rpmlint complains: libpipeline.src: W: spelling-error %description -l en_US execve -> executive, execked, execute IMHO it's OK and does not block the review. # MUST: The License field in the package spec file must match the actual license. [3] Looking at the code, the actual license is GPLv3+, not GPLv3. This should be fixed. # MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [21] The %{?_isa} part is missing in the .spec file. Is it something new? It wasn't required when I did last review (it's a long time ago...). # MUST: Packages must NOT bundle copies of system libraries.[11] gnulib has exception, but Packaging guidelines suggest that the package should Provide: bundled(gnulib) All SHOULD items are OK. Looking at the .spec file itself, I notice few cosmetic nits: - Source0 could contain %{version} so it does not need to be manually updated with every rebase. - Both %description texts should end with dot '.' at the end. - There is additional 'ls -la' in %install section - it does not harm, nor does it help anything. - %post can be simple %post -p /sbin/ldconfig, like %postun is. Feel free to ignore any of these comments. So, apart from the license, suboptimal Requires: in devel subpackage and missing Provides:bundled(gnulib) the package is IMHO fine to be approved.
Thanks for the review, all points except %post section one fixed, updated srpm and spec.
I approve the package.
New Package SCM Request ======================= Package Name: libpipeline Short Description: A pipeline manipulation library Owners: varekova Branches: InitialCC:
Git done (by process-git-requests).