Bug 700226 - Can't multi-select and delete more than 1 configuration history
Summary: Can't multi-select and delete more than 1 configuration history
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: Core UI
Version: 4.0.0.Beta2
Hardware: All
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: John Mazzitelli
QA Contact: Corey Welton
URL:
Whiteboard:
Depends On:
Blocks: config, individual-config jon3
TreeView+ depends on / blocked
 
Reported: 2011-04-27 20:11 UTC by Mike Foley
Modified: 2011-05-24 01:14 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Embargoed:


Attachments (Terms of Use)

Description Mike Foley 2011-04-27 20:11:47 UTC
Description of problem:
Can't multi-select and delete more than 1 configuration history for a resource.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1.  On any resource's configuration, make some changes so there are 3 or more configuration histories.
2.  Multi-select 2 configuration histories (not including the current)
3.  Hit the delete button.
  
Actual results:
only1 configuration history is deleted.

Expected results:
the selected configuration histories would be deleted.

Additional info:

Comment 1 John Mazzitelli 2011-04-28 13:46:53 UTC
this is an easy fix, we should fix this for release:

   doomedIds[i] = selected.getAttributeAsInt(AbstractConfigurationHistoryDataSource.Field.ID);

we forgot to increment i:

   doomedIds[i++] = selected.getAttributeAsInt(AbstractConfigurationHistoryDataSource.Field.ID);

Comment 2 John Mazzitelli 2011-04-28 13:53:15 UTC
commit 0bbe5a5 in master - we should cherry pick this over, its a trivial fix and is clearly the solution to this bug

Comment 3 John Mazzitelli 2011-04-28 14:29:43 UTC
release-4.0.0 branch commit: 4ae8ecc92c1f96bd9d1bf1ce5c1a4b7935c1ab53

Comment 4 Sunil Kondkar 2011-05-05 11:13:44 UTC
Verified on rhq4 release build. (Version: 4.0.0 Build Number: db0c817)

Selected 2 configuration histories on resource config history page and deleted them successfully.

Marking as verified.

Comment 5 Corey Welton 2011-05-24 01:14:27 UTC
Bookkeeping - closing bug - fixed in recent release.

Comment 6 Corey Welton 2011-05-24 01:14:27 UTC
Bookkeeping - closing bug - fixed in recent release.

Comment 7 Corey Welton 2011-05-24 01:14:27 UTC
Bookkeeping - closing bug - fixed in recent release.


Note You need to log in before you can comment on or make changes to this bug.