Bug 700353 - Review Request: perl-HTTP-OAI - API for the OAI-PMH
Summary: Review Request: perl-HTTP-OAI - API for the OAI-PMH
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-04-28 08:04 UTC by Nicholas van Oudtshoorn
Modified: 2011-12-30 00:59 UTC (History)
4 users (show)

Fixed In Version: perl-HTTP-OAI-3.27-1.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-15 02:27:51 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Nicholas van Oudtshoorn 2011-04-28 08:04:55 UTC
Spec URL: http://dl.dropbox.com/u/8648526/perl-HTTP-OAI.spec
SRPM URL: http://dl.dropbox.com/u/8648526/perl-HTTP-OAI-3.24-1.fc14.src.rpm
Description:

This is one of the requirements for the Koha Library Management System.

Since I have not yet got any packages in the fedora repository, I am looking for a sponsor.

Comment 1 Iain Arnell 2011-10-27 03:03:06 UTC
Nicholas has a sponsor - no need to block FE-NEEDSPONSOR any more.

Comment 2 Parag AN(पराग) 2011-11-17 06:18:59 UTC
Suggestions:
1) If building this on Fedora only then you don't need
  a) buidlroot
  b) cleaning of buildroot in %install
  c) %clean section
  d) defattr(-,root,root,-)

2) Please submit a new updated package with 3.27 release.

3) Perl packages should get their required packages installed automatically using yum. So you don't need to specify Requires: in spec. Only those packages that yum fails to install need to be added as Requires:

When you generate a spec using cpanspec it generally contains all the required packages as Requires:

Comment 3 Parag AN(पराग) 2011-11-28 05:21:15 UTC
ping for update here also :)

Comment 4 Nicholas van Oudtshoorn 2011-11-28 05:35:31 UTC
Pung! (And updated files):

Spec URL: http://dl.dropbox.com/u/8648526/packaging/perl-HTTP-OAI.spec
SRPM URL: http://dl.dropbox.com/u/8648526/packaging/perl-HTTP-OAI-3.27-1.fc16.src.rpm

Comment 5 Parag AN(पराग) 2011-11-28 09:29:49 UTC
Review:-

+ koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3545432

+ rpmlint on rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ source verified with upstream as  (sha1sum)
c9a777877e2ad73455b28052841ef0806794883d  HTTP-OAI-3.27.tar.gz
c9a777877e2ad73455b28052841ef0806794883d  ../SOURCES/HTTP-OAI-3.27.tar.gz

+ make test gave
All tests successful.
Files=12, Tests=77,  3 wallclock secs ( 0.06 usr  0.02 sys +  2.09 cusr  0.25 csys =  2.42 CPU)

+ Package: perl-HTTP-OAI-3.27-1.fc17.noarch

Provides: perl(HTTP::OAI) = 3.27 perl(HTTP::OAI::Debug) perl(HTTP::OAI::Encapsulation) perl(HTTP::OAI::Encapsulation::DOM) perl(HTTP::OAI::Error) perl(HTTP::OAI::FilterDOMFragment) perl(HTTP::OAI::GetRecord) perl(HTTP::OAI::Harvester) perl(HTTP::OAI::Header) perl(HTTP::OAI::Headers) perl(HTTP::OAI::Identify) perl(HTTP::OAI::ListIdentifiers) perl(HTTP::OAI::ListMetadataFormats) perl(HTTP::OAI::ListRecords) perl(HTTP::OAI::ListSets) perl(HTTP::OAI::Metadata) perl(HTTP::OAI::Metadata::METS) perl(HTTP::OAI::Metadata::OAI_DC) perl(HTTP::OAI::Metadata::OAI_Eprints) perl(HTTP::OAI::Metadata::OAI_Identifier) perl(HTTP::OAI::MetadataFormat) perl(HTTP::OAI::PartialList) perl(HTTP::OAI::Record) perl(HTTP::OAI::Repository) perl(HTTP::OAI::Response) perl(HTTP::OAI::ResumptionToken) perl(HTTP::OAI::SAXHandler) perl(HTTP::OAI::Set) perl(HTTP::OAI::UserAgent) perl(XML::SAX::Debug)


Requires: /usr/bin/perl perl(CGI) perl(Carp) perl(Data::Dumper) perl(Encode) perl(Exporter) perl(HTTP::Headers) perl(HTTP::OAI) perl(HTTP::OAI::Debug) perl(HTTP::OAI::Encapsulation) perl(HTTP::OAI::Error) perl(HTTP::OAI::GetRecord) perl(HTTP::OAI::Harvester) perl(HTTP::OAI::Header) perl(HTTP::OAI::Headers) perl(HTTP::OAI::Identify) perl(HTTP::OAI::ListIdentifiers) perl(HTTP::OAI::ListMetadataFormats) perl(HTTP::OAI::ListRecords) perl(HTTP::OAI::ListSets) perl(HTTP::OAI::Metadata) perl(HTTP::OAI::Metadata::OAI_DC) perl(HTTP::OAI::MetadataFormat) perl(HTTP::OAI::PartialList) perl(HTTP::OAI::Record) perl(HTTP::OAI::Repository) perl(HTTP::OAI::Response) perl(HTTP::OAI::ResumptionToken) perl(HTTP::OAI::SAXHandler) perl(HTTP::OAI::Set) perl(HTTP::OAI::UserAgent) perl(HTTP::Request) perl(HTTP::Response) perl(LWP::UserAgent) perl(POSIX) perl(Pod::Usage) perl(URI) perl(XML::LibXML) perl(XML::LibXML::SAX) perl(XML::LibXML::SAX::Builder) perl(XML::LibXML::SAX::Parser) perl(XML::LibXML::XPathContext) perl(XML::SAX) perl(XML::SAX::ParserFactory) perl(bytes) perl(constant) perl(lib) perl(overload) perl(strict) perl(utf8) perl(vars) perl(warnings)

+ rest follows packaging guidelines


APPROVED.

Comment 6 Nicholas van Oudtshoorn 2011-12-13 01:59:53 UTC
New Package SCM Request
=======================
Package Name: perl-Authen-CAS-Client
Short Description: he Authen::CAS::Client module provides a simple interface for
authenticating users using JA-SIG's CAS protocol. Both CAS v1.0 and v2.0
are supported.
Owners: vanoudt
Branches: f15 f16
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2011-12-13 02:32:16 UTC
Review summary and SCM request package names don't match, please correct.

Comment 8 Nicholas van Oudtshoorn 2011-12-13 03:26:33 UTC
Doh! Gotta hate copy and paste errors. Apologies for the time-stealing. Here's the proper SCM Request!

New Package SCM Request
=======================
Package Name: perl-HTTP-OAI
Short Description: API for the OAI-PMH
Owners: vanoudt
Branches: f15 f16
InitialCC: perl-sig

Comment 9 Gwyn Ciesla 2011-12-13 04:33:55 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2011-12-15 02:28:43 UTC
perl-HTTP-OAI-3.27-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/perl-HTTP-OAI-3.27-1.fc16

Comment 11 Fedora Update System 2011-12-30 00:59:40 UTC
perl-HTTP-OAI-3.27-1.fc16 has been pushed to the Fedora 16 stable repository.


Note You need to log in before you can comment on or make changes to this bug.