Red Hat Bugzilla – Bug 700450
Resource leaks revealed by Coverity scan.
Last modified: 2015-03-04 18:57:27 EST
1. Function "file_struct" in /flist.c:1326 returns NULL without deallocation variable file.
flist.c:1332: file = make_file(fname, flist, stp, flags, filter_level);
flist.c:1362, 1392, 1406, 1424, 1433: return without free.
2. Missing deallocations in fucntion "start_client"(/main.c:1107).
Function "check_for_hostspec" allocates memory to its second parameter and
this memory is not freed(/main.c:1211, 1122, 1199, 1162)
Version-Release number of selected component (if applicable):
Additional info: These defects were not present in current supported version of rsync package.
Confirmed, both resource leaks are also in rsync 3.0.8. I will send the patches upstream.
Created attachment 501933 [details]
proposed patch for 2nd leak
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.
I've tracked down the issue reported in bug #724041 to rsync-3.0.6-free-hostnames.patch which seems to be related to this report.