Hide Forgot
Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/wmsystemtray.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/wmsystemtray-1.2-1.fc14.src.rpm Description: wmsystemtray is a system tray using the freedesktop.org system tray protocol designed as a Window Maker dock app. It has the ability to display more than one dock window to make room for more tray icons, and the ability to scroll through the icons if more are present than will fit. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3035792
Packaging is good, I just noticed two issues: - the bluid root clean is useless nowadays in %install, as well as the %clean target; - The package may requires the xorg-x11-fonts-misc package, otherwise the applet cannot be launched.
Thanks for the hints. New files: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/wmsystemtray.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/wmsystemtray-1.2-2.fc15.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3528684
Here is the review: +:ok, =:needs attention, -:needs fixing MUST Items: [+] MUST: rpmlint must be run on every package. wmsystemtray.src: W: spelling-error Summary(en_US) freedesktop -> free desktop, free-desktop, desktop wmsystemtray.src: W: spelling-error Summary(en_US) systray -> stray wmsystemtray.src: W: spelling-error %description -l en_US freedesktop -> free desktop, free-desktop, desktop wmsystemtray.x86_64: W: spelling-error Summary(en_US) freedesktop -> free desktop, free-desktop, desktop wmsystemtray.x86_64: W: spelling-error Summary(en_US) systray -> stray wmsystemtray.x86_64: W: spelling-error %description -l en_US freedesktop -> free desktop, free-desktop, desktop 3 packages and 0 specfiles checked; 0 errors, 6 warnings. These warnings can be safely ignored. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name} [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. MD5 sum=425b3cc8fc717a997a67706b8013ad21 -> OK [+] MUST: The package must successfully compile and build into binary rpms on at least one supported architecture. [+] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. [+] MUST: All build dependencies must be listed in BuildRequires [+] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. [+] MUST: Every binary RPM package which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [+] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A package must not contain any duplicate files in the %files listing. [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. [+] MUST: The package must contain code, or permissible content. This is described in detail in the code vs. content section of Packaging Guidelines. [+] MUST: Large documentation files should go in a doc subpackage. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [+] MUST: Static libraries must be in a -static package. [+] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [+] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. ->Exception validated here (see https://bugzilla.redhat.com/show_bug.cgi?id=478744#c4) [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. This package is APPROVED.
Mohamed, many thanks for your review. New Package SCM Request ======================= Package Name: wmsystemtray Short Description: System tray (freedesktop.org systray protocol) as a Window Maker dock app Owners: mariobl Branches: f15 f16
Git done (by process-git-requests).
wmsystemtray-1.2-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/wmsystemtray-1.2-2.fc16
wmsystemtray-1.2-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/wmsystemtray-1.2-2.fc15
wmsystemtray-1.2-2.fc15 has been pushed to the Fedora 15 testing repository.
wmsystemtray-1.2-2.fc15 has been pushed to the Fedora 15 stable repository.
wmsystemtray-1.2-2.fc16 has been pushed to the Fedora 16 stable repository.