The ds_bring_up_server_install() function looks to have some cut/paste errors in it that throw off the intended logic.
If XP_WIN32 is not defined, the else at line 256 is a part of the if at line 246. If XP_WIN32 is defined, the else at line 256 is a part of the if at line 227, which seems wrong.
It also seems like the if statement at line 227 should be closed out after line 237. The intent looks to be that we want to print the contents of statfile is the verbose option is set. The code beginning at line 239 seems unrelated to the verbose option, as it's setting the status that gets returned.
This could be some sort of copy/paste area wince the if/else block beginning at line 207 seems the same as the if/else block starting at line 239. There is definitely some cleanup to be done here.
Created attachment 495819 [details]
Patch for cov#10778
Pushed patch to master. Thanks to Noriko for her review!
Counting objects: 9, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 944 bytes, done.
Total 5 (delta 3), reused 0 (delta 0)
9047b26..cc422c4 master -> master
coverity is clean - marking verified