Spec URL: http://ares.ptitoliv.net/~ptitoliv/fedora/smarty-gettext/smarty-gettext.spec SRPM URL: http://ares.ptitoliv.net/~ptitoliv/fedora/smarty-gettext/smarty-gettext-1.0b1-1.fc14.src.rpm Description: Smarty gettext plug-in provides an internationalization support for the PHP template engine Smarty. Hello, I submit this Review Request to the Fedora Package team in order to integrate this library in the next Fedora Release. It is my first package, so I request a sponsor for my first review process. Thanks a lot.
Some notes (not a review) - version is not correct for a pre-release version (1.0-0.1.b1) http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages - use a simple sed instead of dos2unix (avoid dependency) - don't install doc, list them in %file is enough %doc README COPYING Changelog - what is the goal of the 01_fix_binary_license.patch ? only to change "space" (diff -b is empty) ? I don't think it is really usefull... - name is not correct http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28General.29 and http://fedoraproject.org/wiki/Packaging/PHP#Naming_scheme - removing .php suffix from installed binary seems a good idea - shebang must be fixed ("/usr/bin/env php" => %{_bindir}/php)
Hello, Thanks for your comments. I considered all your remarks and made new spec file. You can find : - The SPEC file : http://ares.ptitoliv.net/~ptitoliv/fedora/smarty-gettext/smarty-gettext.spec - The SRPM file : http://ares.ptitoliv.net/~ptitoliv/fedora/smarty-gettext/php-Smarty-gettext-1.0-0.1.b1.fc14.src.rpm Regards,
- spec file name must be fixed http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Spec_file_name - use install with -p option to preserve file timestamp - sed are unreadable, use special substitution instead - should preserve timestamp on upstream as much as possible per exemple : # UNIX format conversion for fic in ChangeLog README COPYING; do touch -r $fic .timestamp sed -i -e 's/\f//;s/\r//' $fic touch -r .timestamp $fic done - remove rm -rf %{buildroot} in %prep $ rpmlint -I rpm-buildroot-usage rpm-buildroot-usage: $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may break short circuit builds. -add rm -rf %{buildroot} in %install - issue with license file $ rpmlint -I incorrect-fsf-address incorrect-fsf-address: The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. You should, at least, open an upstream bug (don't know if he's alive, as this 1.0b1 seems quite old... 2005)
Hello, Here is a new version considering the last notes : - SPEC file : http://ares.ptitoliv.net/~ptitoliv/fedora/smarty-gettext/php-Smarty-gettext.spec - SRPM file : http://ares.ptitoliv.net/~ptitoliv/fedora/smarty-gettext/php-Smarty-gettext-1.0-0.1.b1.fc14.src.rpm Regards,
Hello, I have made a new version considering the new recommendations provided by the FC15 rpmlint software. - SPEC file : http://ares.ptitoliv.net/~ptitoliv/fedora/smarty-gettext/php-Smarty-gettext.spec - SRPM file : http://ares.ptitoliv.net/~ptitoliv/fedora/smarty-gettext/php-Smarty-gettext-1.0-0.2.b1.fc15.src.rpm Regards,
Hello, I just repackaged the php-Smarty-gettext library for FC16. You'll find the elements here : - SPEC File : http://ares.ptitoliv.net/~ptitoliv/fedora/smarty-gettext/php-Smarty-gettext.spec - SRPM File : http://ares.ptitoliv.net/~ptitoliv/fedora/smarty-gettext/php-Smarty-gettext-1.0-0.2.b1.fc16.src.rpm Regards,
Hello, Here is the new RPM for the smarty gettext library rebuilt for Fedora 17. The main change is the manpage add for the tsmarty2c script. The ressources are here : - SPEC File : http://ares.ptitoliv.net/~ptitoliv/fedora/smarty-gettext/php-Smarty-gettext.spec - SRPM File : http://ares.ptitoliv.net/~ptitoliv/fedora/smarty-gettext/php-Smarty-gettext-1.0-0.3.b1.fc17.src.rpm. Moreover, since the project is inactive since years, it is planned to fork or recover the upstream project in order to import patches and updates. Regards,
Olivier, are you still around and interested?
Hello Matthias, Of course I am. The smarty-gettext lib is still used by our project Fusiondirectory which is still looking for a sponsor. Regards, Olivier
OK, I'll do a review, and also could sponsor you.
some drive-by comments: - please drop buildroot definition, it's not required any more - please drop provides and obsoletes, esp. the latter doesn't make sense at all here - please remove the clean section, not required any more - please update to latest release. - please drop defattr in files section, not required any more
Any progress here?
Closing this. Please open another one, when you're ready.