Bug 701757 - can't get proper WM_CLASS association for LibreOffice
Summary: can't get proper WM_CLASS association for LibreOffice
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-shell
Version: 15
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Owen Taylor
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-05-03 19:06 UTC by Bill Nottingham
Modified: 2014-03-17 03:27 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-07 17:39:37 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
GNOME Bugzilla 649315 0 None None None Never

Description Bill Nottingham 2011-05-03 19:06:22 UTC
gnome-shell-3.0.1-1.fc15.x86_64
libreoffice-core-3.3.2.2-6.fc15.x86_64

<notting> is there a plan to 'fix' the libreoffice icons?
<cosimoc> notting, fix as in?
<notting> cosimoc: they're being scaled badly
 at least in the task switcher
<cosimoc> hrm, they look good here
<owen> notting: is assoication working?
 notting: what d you see for the app icon?
<cosimoc> notting, but if they look fine in Applications and not in alt-tab icons are not the issue usually
<owen> notting: do you see the text you'd expect, or something weirdly capitalized with dashes?
<cosimoc> it's the application that does not the right WM class
<notting> owen: what looks to be a 32x32 (or 48x48, whatever) version of the correct icon, scaled up 
<owen> notting: i"M actually asking about the text
 notting: up by Activities
<notting> owen: 'libreoffice-calc'
<owen> notting: yeah, that's what I expected
 notting: and does /usr/share/applications/libreoffice-calc.desktop exist?
<owen> (and do you have appications under Applications in the overview?)
<notting> that desktop exists
 and i have 'LibreOffice Calc' in applications -> office
<owen> notting: hmm, I'm puzzled
 notting: what is xprop | grep WM_CLASS ?
<owen> notting: how did you get to this document? I'm wondering if there is some code path where LO isn't correctly setting the right WM_CLASS
<notting> WM_CLASS(STRING) = "VCLSalFrame.DocumentWindow", "libreoffice-calc"
 WM_ICON_NAME(STRING) = "configtool.ods - LibreOffice Calc"
 owen: "ooffice <blah>" ran from the terminal, of course
<owen> notting: the WM_CLASS looks fine really
 notting: what does the Windows tab sow?
<owen> walters: my current guess is that libreofice changes WM_CLASS after mapping the window and we don't handle that correctly and are racy
<notting> wmclass: libreoffice-calc, <untracked>
<walters> owen: that looks to be the case indeed
<walters> i'm not sure i'd call that our bug though
<owen> walters: well, consiering the weird container nature of openoffice
<walters> hmm
<owen> walters: it may be heroic of them to get the WM_CLASS set correctly *at all*
<walters> is this something where like it decides which app it is after it's already opened the document?
<owen> walters: I'm guessing so
 walters: we can check with caolon of course, but if it's not too much work to handle it, we possible should
<walters> notting: file a bug, i'll take a look
<owen> notting: does it work better if you run libreoffice-calc <document> ?
 notting: and/or is it sometimes-work-sometimes-not ?
<walters> owen: nope
<notting> can't make it work, even running as 'oocalc'
 or /usr/lib64/libreoffice/program/scalc, even

Comment 1 Caolan McNamara 2011-05-24 12:53:56 UTC
Indeed, you guys wanted WM_CLASS set to libreoffice-something and it is. I also stated that because you can open e.g. a writer frame, close it to a sort of empty startcenter frame and open e.g. a calc in that frame that the WM_CLASS could change. 

So, easy way to reproduce that is to...

a) launch writer, calls itself libreoffice-writer
b) close the writer internal window to go to empty startcenter, calls itself libreoffice-startcenter
c) launch calc in it, calls itself libreoffice-calc

alt-tab icon stays stuck as the libreoffice-writer icon.

Comment 2 Colin Walters 2011-05-24 13:38:17 UTC
(In reply to comment #1)
> Indeed, you guys wanted WM_CLASS set to libreoffice-something and it is. I also
> stated that because you can open e.g. a writer frame, close it to a sort of
> empty startcenter frame and open e.g. a calc in that frame that the WM_CLASS
> could change. 

That's fine, we should be handling this; I'll make sure it happens for 3.2.

Comment 3 Colin Walters 2011-05-25 00:06:24 UTC
Done upstream.

Comment 4 Eduardo VM 2011-06-09 23:24:03 UTC
I'm facing this same issue: if I open any LibreOffice application directly it renders ok the alt-tab icon. Top panel reads: LibreOffice-Writer. On the contrary, if I open a document, an icon belonging hicolors (probably 48x48) is used. lg reports this one as <untracked>, while the other has libreoffice-writer.desktop. A screenshot: http://dl.dropbox.com/u/11266870/Screenshot-1.png

Comment 5 Eduardo VM 2011-06-09 23:26:30 UTC
Forgot to mention: Top panel on second case reads: LibreOffice 3.3

Comment 6 Fedora End Of Life 2012-08-07 17:39:39 UTC
This message is a notice that Fedora 15 is now at end of life. Fedora
has stopped maintaining and issuing updates for Fedora 15. It is
Fedora's policy to close all bug reports from releases that are no
longer maintained. At this time, all open bugs with a Fedora 'version'
of '15' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that
we were unable to fix it before Fedora 15 reached end of life. If you
would still like to see this bug fixed and are able to reproduce it
against a later version of Fedora, you are encouraged to click on
"Clone This Bug" (top right of this page) and open it against that
version of Fedora.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

The process we are following is described here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping


Note You need to log in before you can comment on or make changes to this bug.