Spec URL: http://water-spirits.net/lazyadmin-stuff/php-pecl-yaml.spec SRPM URL: http://water-spirits.net/lazyadmin-stuff/php-pecl-yaml-1.0.1-2.fc15.src.rpm Description: The YAML PHP Extension provides a wrapper to the LibYAML library. It gives the user the ability to parse YAML document streams into PHP constructs and emit PHP constructs as valid YAML 1.1 documents. $ rpmlint php-pecl-yaml-1.0.1-2.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. I'm not yet a Fedora packager, so I'll need a sponsor.
I will do the review (and can sponsor you, I will contact you by mail about what I'm waiting for) Quick notes: - should requires php-devel >= 5.2.0 (according to upstream) - php_apiver macro is not used - is your patch reported upstream ? - upstream provides a test suite which should be run during %check - More comments in the provided .ini could be usefull (documentation purpose) ====== for test suite %check cd %{pecl_name}-%{version} make test NO_INTERACTION=1 | tee ../rpmtests.log if grep -q "FAILED TEST" ../rpmtests.log; then exit 1 fi ===== for yaml.ini ; %{pecl_name} extension configuration ; see http://www.php.net/manual/en/yaml.configuration.php ; Decode entities which have the explicit tag "tag:yaml.org,2002:binary" yaml.decode_binary = 0 ; Controls the decoding of "tag:yaml.org,2002:timestamp" ; 0 will not apply any decoding, 1 will use strtotime() 2 will use date_create(). yaml.decode_timestamp = 0 ; Cause canonical form output. yaml.output_canonical = 0 ; Number of spaces to indent sections. Value should be between 1 and 10. yaml.output_indent = 2 ; Set the preferred line width. -1 means unlimited. yaml.output_width = 80
Many thanks for taking the review. I've filed an upstream bug with the patch[1] and made the changes you recommended. The updated package is at: Spec URL: http://water-spirits.net/lazyadmin-stuff/php-pecl-yaml.spec SRPM URL: http://water-spirits.net/lazyadmin-stuff/php-pecl-yaml-1.0.1-4.fc15.src.rpm $ rpmlint php-pecl-yaml-1.0.1-4.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [1] http://pecl.php.net/bugs/bug.php?id=22703
=== FORMAL REVIEW === -=N/A x=Check !=Problem, ?=Not evaluated === REQUIRED ITEMS === [ ] Rpmlint output: php-pecl-yaml.spec: I: checking-url http://pecl.php.net/get/yaml-1.0.1.tgz (timeout 10 seconds) php-pecl-yaml.src: I: checking php-pecl-yaml.src: I: checking-url http://code.google.com/p/php-yaml/ (timeout 10 seconds) php-pecl-yaml.src: I: checking-url http://pecl.php.net/get/yaml-1.0.1.tgz (timeout 10 seconds) php-pecl-yaml.x86_64: I: checking php-pecl-yaml.x86_64: I: checking-url http://code.google.com/p/php-yaml/ (timeout 10 seconds) php-pecl-yaml-debuginfo.x86_64: I: checking php-pecl-yaml-debuginfo.x86_64: I: checking-url http://code.google.com/p/php-yaml/ (timeout 10 seconds) 3 packages and 1 specfiles checked; 0 errors, 0 warnings. [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the PHP specific items [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: MIT [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. md5sum : d8a965479d919e1526dd43295783c7f7 yaml-1.0.1.tgz [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: f15.x86_64 [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Packages don't bundle copies of system librarie [x] Package is not relocatable. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -static subpackage, if present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages with %{?_isa}, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI [x] All filenames in rpm packages must be valid UTF-8 [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Final requires php(zend-abi) = 20090626-x86-64 php(api) = 20090626-x86-64 /usr/bin/pecl libyaml-0.so.2()(64bit) ... [x] Final provides php-pecl(yaml) = 1.0.1 php-pecl-yaml = 1.0.1-4.fc15.remi php-pecl-yaml(x86-64) = 1.0.1-4.fc15.remi [x] Latest version is packaged. [-] If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-] The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: Koji http://koji.fedoraproject.org/koji/taskinfo?taskID=3072717 [ ] The package should compile and build into binary rpms on all supported architectures. Tested on: rawhide i66 and x86_64 [x] Package functions as described. [x] If scriptlets are used, those scriptlets must be sane. [x] If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [-] your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. [-] The placement of pkgconfig(.pc) files is correct. [x] %check is present and the tests pass **** APPROVED **** (of course, you must wait for sponsorship before you open SCM admin request)
New Package SCM Request ======================= Package Name: php-pecl-yaml Short Description: Support for YAML 1.1 serialization using the LibYAML library Owners: antiaircraft Branches: f14 f15 InitialCC:
Git done (by process-git-requests).
php-pecl-yaml-1.0.1-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/php-pecl-yaml-1.0.1-4.fc15
php-pecl-yaml-1.0.1-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/php-pecl-yaml-1.0.1-4.fc14
php-pecl-yaml-1.0.1-4.fc14 has been pushed to the Fedora 14 testing repository.
php-pecl-yaml-1.0.1-4.fc14 has been pushed to the Fedora 14 stable repository.
php-pecl-yaml-1.0.1-4.fc15 has been pushed to the Fedora 15 stable repository.
Package Change Request ====================== Package Name: php-pecl-yaml New Branches: el6 epel7 Owners: remi InitialCC: antiaircraft