Spec URL: http://jcollie.fedorapeople.org/osm-gps-map.spec SRPM URL: http://jcollie.fedorapeople.org/osm-gps-map-0.7.3-1.fc15.src.rpm Description: A Gtk+ widget that when given GPS co-ordinates, draws a GPS track, and points of interest on a moving map display. Downloads map data from a number of websites, including openstreetmap.org. Scratch build here: http://koji.fedoraproject.org/koji/taskinfo?taskID=3049662
> License: GPLv3 The included file COPYING is GPLv2. The source files include GPLv2 headers. Upstream web page says "GPLv3", so please ask them to clarify. > Name: osm-gps-map > Group: Development/Libraries The group for library base packages typically is "System Environment/Libraries". > Summary: A Gtk+ widget for displaying OpenStreetMap tiles I still think we should get rid of even more "A", "An", "The" articles at the beginning of these summaries. It makes a better reading during installation and in package installer tools. Your summary for the -devel package also doesn't start with "The". ;) > %description > A Gtk+ widget (and Python bindings) ... The Python bindings are not included in this package, but in a separate one. > %doc AUTHORS COPYING README What about file NEWS? > %files devel > %doc COPYING It is not necessary to duplicate that file in the subpackage. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing > make %{?_smp_mflags} Consider using make V=1 %{?_smp_mflags} so the build output is less silent and e.g. shows full compiler flags. > osm-gps-map v0.7.3 > Prefix............... : /usr > libsoup.............. : 2.4 > Introspection support : no > gtk-doc documentation : no $ grep -i introspec build.log checking for gobject-introspection... no Introspection support : no
Michael, I've addressed your comments. For now, if the source says GPLv2 that's what I'll go with. I'll work with upstream to clarify in the future. I also explicitly disabled gobject introspection because it doesn't compile correctly on F15 and from what I can tell isn't that interesting on F14. Here's a new scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3055990 and a link to the new SRPM: http://jcollie.fedorapeople.org/osm-gps-map-0.7.3-2.fc15.src.rpm
The added BuildRequires cairo-gobject-devel isn't needed, is it? Other than that, the rpmdev-diff output looks fine. APPROVED
Michael, thanks for the review. Yes, the cairo-gobject-devel is not necessary, I added that when I was testing the gobject introspection but forgot to take it back out. I'll fix that when I import the package. New Package SCM Request ======================= Package Name: osm-gps-map Short Description: Gtk+ widget for displaying OpenStreetMap tiles Owners: jcollie Branches: devel f15 f14 f13 InitialCC:
Git done (by process-git-requests).
osm-gps-map-0.7.3-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/osm-gps-map-0.7.3-3.fc15
osm-gps-map-0.7.3-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/osm-gps-map-0.7.3-3.fc14
osm-gps-map-0.7.3-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/osm-gps-map-0.7.3-3.fc13
osm-gps-map-0.7.3-3.fc15 has been pushed to the Fedora 15 testing repository.
osm-gps-map-0.7.3-3.fc15 has been pushed to the Fedora 15 stable repository.
osm-gps-map-0.7.3-3.fc14 has been pushed to the Fedora 14 stable repository.
osm-gps-map-0.7.3-3.fc13 has been pushed to the Fedora 13 stable repository.