+++ This bug was initially created as a clone of Bug #695767 +++
1) "gfs2_edit savemeta" should compress metadata.
2) "gfs2_edit restoremeta" should decompress the metadata if it recognises the file as being compressed
Things to decide:
a) Preference of bzip2, gzip, or other for compression?
b) --nozip flag to turn off the feature and just save the metadata as before?
--- Additional comment from email@example.com on 2011-04-13 09:23:23 EDT ---
Created attachment 491757 [details]
Attaching a first attempt patch. The usually restoremeta warnings apply.
--- Additional comment from firstname.lastname@example.org on 2011-04-14 12:29:24 EDT ---
Created attachment 492167 [details]
This patch adds a -nocompress option, abstracts away the calls to write/gzwrite, and adds more documentation. It also uses compression level 5 instead of the default 6 as it seems to speed up the compression significantly with very little effect on the compressed file size (for my small test cases at least).
--- Additional comment from email@example.com on 2011-05-04 14:02:14 EDT ---
Created attachment 496861 [details]
This revision of the patch replaces the -nocompress option with the -z <0-9> option and removes the unnecessary strdup() mentioned on the mailing list.
--- Additional comment from firstname.lastname@example.org on 2011-05-05 05:50:20 EDT ---
Third patch is now in gfs2_utils.git master
pm_ack granted for RHEL 6.2 inclusion.
Patch is now in the RHEL6 branch of cluster.git, ref: 103de0c93a208ae96b9771b8d7410e0537af9327
Since this is a FutureFeature, development needs to show some functional test results. Please show option is available in gfs2-utils-184.108.40.206-2.el6 and is working as expected.
Created attachment 504874 [details]
Additional patch for RHEL6
Further testing threw up a problem with the older zlib version in RHEL6. This additional patch makes my tests pass and is now in the RHEL6 branch of cluster.git, so setting back to POST.
The above patch is now in build cluster-220.127.116.11-3.el6
Created attachment 505016 [details]
Test results from /CoreOS/gfs2-utils/Sanity/bz695767-savemeta-compression-test
Verified against gfs2-utils-18.104.22.168-7.el6.x86_64
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
Previous versions of gfs2_edit saved GFS2 metadata uncompressed.
Saved GFS2 metadata sets could take up a lot of storage space and transferring them (e.g. for support and debugging) would be slow.
gzip compression was added to the metadata saving and restoring functions of gfs2_edit.
GFS2 metadata sets are now compressed when saving and decompressed when restoring. The user can specify the compression level with a command line option.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.