Bug 703193 - support enabling/disabling xen hpet
Summary: support enabling/disabling xen hpet
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: libvirt
Version: 5.7
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: rc
: ---
Assignee: Paolo Bonzini
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On: 702607
Blocks: 699611 702652
TreeView+ depends on / blocked
 
Reported: 2011-05-09 15:42 UTC by Paolo Bonzini
Modified: 2011-07-21 10:32 UTC (History)
20 users (show)

Fixed In Version: libvirt-0.8.2-20.el5
Doc Type: Bug Fix
Doc Text:
Clone Of: 702607
Environment:
Last Closed: 2011-07-21 10:32:08 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2011:1019 0 normal SHIPPED_LIVE Moderate: libvirt security, bug fix, and enhancement update 2011-07-21 10:31:00 UTC

Comment 1 Daniel Berrangé 2011-05-10 11:41:17 UTC 
Fortunately we already have XML syntax for configuring timers. For HPET you can toggle it on/off with something like:

  <clock offset='utc'>
    <timer name='hpet' present='yes|no'/>
  </clock>

So this simply needs to be wired up to the Xen SEXPR and XM config file convertors and it'll work with Xen.
Comment 2 Eric Blake 2011-05-10 22:42:01 UTC 
In POST:
http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-May/msg00141.html
Comment 4 Vivian Bian 2011-05-12 03:44:31 UTC 
tested with 
libvirt-0.8.2-20.el5
xen-3.0.3-130.el5
kernel-2.6.18-259.el5

Steps:
[root@localhost libvirt]# virsh edit win2k3
Domain win2k3 XML configuration edited.

[root@localhost libvirt]# virsh start win2k3
Domain win2k3 started

[root@localhost libvirt]# virsh dumpxml win2k3 |grep hpet
    <timer name='hpet' present='yes'/>
[root@localhost libvirt]# cat /etc/xen/win2k3 |grep hpet
hpet = 1
[root@localhost libvirt]# virsh destroy win2k3
Domain win2k3 destroyed

[root@localhost libvirt]# virsh edit win2k3
Domain win2k3 XML configuration edited.

[root@localhost libvirt]# virsh start win2k3
Domain win2k3 started

[root@localhost libvirt]# virsh dumpxml win2k3|grep hpet
    <timer name='hpet' present='no'/>
[root@localhost libvirt]# cat /etc/xen/win2k3 |grep hpet
hpet = 0
tap,vlan=1,bridge=virbr0 -vnc 127.0.0.1:10 -vncunused


According to above result , hpet could be set correctly . So set bug status to VERIFIED
Comment 5 Huming Jiang 2011-06-01 11:47:10 UTC 
could produce this bug on the following components of rh5.6:
kernel-xen-2.6.18-238.el5
xen-3.0.3-120.el5
libvirt-0.8.2-15.el5

steps:
1. virsh dumpxml a
...
  <clock offset='utc'/>
...
2.virsh edit a
  <clock offset='utc'>
    <timer name='hpet' present='yes'/>
  </clock>
3.virsh dumpxml a
...
  <clock offset='utc'/>
...
Comment 6 Paolo Bonzini 2011-06-01 12:34:30 UTC 
see comment 4, support was only introduced in libvirt-0.8.2-20.el5.
Comment 7 errata-xmlrpc 2011-07-21 10:32:08 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-1019.html
Note You need to log in before you can comment on or make changes to this bug.