Spec URL: http://tavvva.net/files/redhat/google-gson/google-gson.spec SRPM URL: http://tavvva.net/files/redhat/google-gson/google-gson-1.7.1-1.fc14.src.rpm Description: Hi. I would appreciate a review for google-gson. Gson is a Java library that can be used to convert a Java object into its JSON representation. It can also be used to convert a JSON string into an equivalent Java object. Gson can work with arbitrary Java objects including pre-existing objects that you do not have source-code of.
I would do this one.
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [!] Rpmlint output: google-gson.noarch: W: spelling-error %description -l en_US pre -> per, ore, pee google-gson.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/google-gson-1.7.1/LICENSE google-gson.noarch: W: non-conffile-in-etc /etc/maven/fragments/google-gson google-gson-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/google-gson-javadoc-1.7.1/LICENSE Fix the license file EOL [x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [x] Package successfully compiles and builds into binary rpms. [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license. License type: ASL 2.0 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [-] Sources used to build the package matches the upstream source, as provided in the spec URL. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [x] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Javadoc documentation files are generated and included in -javadoc subpackage [x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [x] Javadoc subpackages have Require: jpackage-utils [x] Package uses %global not %define [x] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [-] If source tarball includes bundled jar/class files these need to be removed prior to building [x] All filenames in rpm packages must be valid UTF-8. [x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [x] If package contains pom.xml files install it (including depmaps) even when building with ant [x] pom files has correct add_to_maven_depmap call which resolves to the pom file (use "JPP." and "JPP-" correctly) === Maven === [x] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment [-] If package uses custom depmap "-Dmaven2.jpp.depmap.file=*" explain why it's needed in a comment [x] Package uses %update_maven_depmap in %post/%postun [x] Packages have Requires(post) and Requires(postun) on jpackage-utils (for %update_maven_depmap macro) === Other suggestions === [x] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [x] Package has BuildArch: noarch (if possible) [x] Latest version is packaged. [x] Reviewer should test that the package builds in mock. === Issues === 1. Only the EOL Quite good package for first try. I'm impressed.
Thanks a lot! Actually I got few example SRPMs from Stanislav Ochotnicky. He gave me many hints how to deal with java packaging. I'll fix the CR+LF endings asap.
Second release is available here ... Spec URL: http://tavvva.net/files/redhat/google-gson/2/google-gson.spec SRPM URL: http://tavvva.net/files/redhat/google-gson/2/google-gson-1.7.1-2.fc14.src.rpm
Thanks, APPROVED.
Sponsored.
New Package SCM Request ======================= Package Name: google-gson Short Description: Java lib for conversion of Java objects into JSON representation Owners: jcapik Branches: f15 InitialCC: java-sig
Git done (by process-git-requests).
google-gson-1.7.1-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/google-gson-1.7.1-3.fc15
google-gson-1.7.1-3.fc15 has been pushed to the Fedora 15 testing repository.
google-gson-1.7.1-3.fc15 has been pushed to the Fedora 15 stable repository.