gx_head is a simple guitar mono tube amplifier simulation based on the work done in the Guitarix project (same developers) and is under heavy development. SPEC: http://bsjones.fedorapeople.org/gx_head.spec SRPM: http://bsjones.fedorapeople.org/gx_head-0.14.0-1.fc15.src.rpm fedora15:~$ rpmlint rpmbuild/SRPMS/gx_head-0.14.0-1.fc15.src.rpm gx_head.src: W: spelling-error %description -l en_US gx -> g, x, ex gx_head.src: W: spelling-error %description -l en_US tonestack -> tone stack, tone-stack, tones tack gx_head.src: W: spelling-error %description -l en_US autowah -> autobahn gx_head.src: W: spelling-error %description -l en_US phaser -> phase, phrase, phases gx_head.src: W: spelling-error %description -l en_US flanger -> flange, flanges, clanger gx_head.src: W: spelling-error %description -l en_US pre -> per, ore, pee gx_head.src: W: spelling-error %description -l en_US guitarix -> guitar ix, guitar-ix, guitarist gx_head.src: W: spelling-error %description -l en_US funkmuscle -> funk muscle, funk-muscle, musclebound gx_head.src: W: spelling-error %description -l en_US zettberlin -> timberline 1 packages and 0 specfiles checked; 0 errors, 9 warnings.
Hi Brendan, here is my review: ! %description may need some implevement, such as witch -> which could be load -> could be loaded could connected -> could be connected etc ? There are a bunch of files that get installed in /usr/share/gx_head/sounds/ and they have 664 permissions instead of the standard 644. Search for the string "664" in the wscript file. I don't think that this is a blocker but do you know if there is a reason for this? ! In addition to the above rpmlints, which can be ignored, I got the following: gx_head.x86_64: W: no-manual-page-for-binary gx_head ignore this one gx_head.x86_64: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/gx_head.mo gx_head.x86_64: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/gx_head.mo gx_head.x86_64: W: file-not-in-%lang /usr/share/locale/it/LC_MESSAGES/gx_head.mo This is a blocker. We install locales in a special way. See below. some 100+ "incorrect-fsf-address" warnings There was a discussion in the devel list a few days ago. Folks said it would be good to notify the upstream about this issue. * The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. Please see http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
Thanks Orcan - have fixed (and shortened) the sloppy description and the other issues. I will inform upstream about the FSF address change. SPEC: http://bsjones.fedorapeople.org/gx_head.spec SRPM: http://bsjones.fedorapeople.org/gx_head-0.14.0-2.fc15.src.rpm
Thanks. The general convention is to try to fix simple issues in %prep as long as they are easy; for instance you can fix the chmod 644 issue in the wscript file via patch or sed. Otherwise the package looks good. ------------------------------------------ This package (gx_head) is APPROVED by oget ------------------------------------------
Thanks Orcan - I will move into a patch before updating.
New Package SCM Request ======================= Package Name: gx_head Short Description: Mono tube amplifier to JACK Owners: bsjones Branches: f14 f15 InitialCC:
Git done (by process-git-requests).
gx_head-0.14.0-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/gx_head-0.14.0-3.fc15
gx_head-0.14.0-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/gx_head-0.14.0-3.fc14
gx_head-0.14.0-3.fc14 has been pushed to the Fedora 14 testing repository.
This message is a notice that Fedora 15 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 15. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At this time, all open bugs with a Fedora 'version' of '15' have been closed as WONTFIX. (Please note: Our normal process is to give advanced warning of this occurring, but we forgot to do that. A thousand apologies.) Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, feel free to reopen this bug and simply change the 'version' to a later Fedora version. Bug Reporter: Thank you for reporting this issue and we are sorry that we were unable to fix it before Fedora 15 reached end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged to click on "Clone This Bug" (top right of this page) and open it against that version of Fedora. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping