Bug 703703 - setup-ds-admin.pl asks for legal agreement to a non-existant file
Summary: setup-ds-admin.pl asks for legal agreement to a non-existant file
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: 389
Classification: Retired
Component: Install/Uninstall
Version: 1.2.9
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: ---
Assignee: Nathan Kinder
QA Contact: Ben Levenson
URL:
Whiteboard:
Depends On:
Blocks: 690318 389_1.2.9 726742
TreeView+ depends on / blocked
 
Reported: 2011-05-11 05:29 UTC by James Livingston
Modified: 2016-02-22 00:56 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-12-10 18:40:06 UTC
Embargoed:


Attachments (Terms of Use)
0001-Bug-703703-setup-ds-admin.pl-asks-for-legal-agreemen.patch (2.86 KB, patch)
2011-06-20 19:11 UTC, Rich Megginson
nkinder: review+
Details | Diff

Description James Livingston 2011-05-11 05:29:58 UTC
Description of problem:
setup-ds-admin.pl requires that you agree to be bound by the agreement in "LICENSE.TXT". That is no file with that name.

I guess it is referring to /usr/share/doc/389-admin-1.1.16/LICENSE, but since it's asking for legal agreement, it would be good not to guess and point to the exact path of the file I'm supposed to be agreeing to


Version-Release number of selected component (if applicable):
1.1.16-1.fc14

How reproducible:
always

Steps to Reproduce:
1. Run setup-ds-admin.pl
2. Take note of the file name it says the licence is in
3. Try to find the file, to read it before agreeing
  
Actual results:
Cannot find the file

Expected results:
To be able to find the file

Additional info:

Comment 1 Rich Megginson 2011-06-18 01:20:26 UTC
There are actually several different licenses
directory server is GPLv2 + plugin exception
admin server is mostly GPLv2 except for the Apache modules which are APL2
the rest of the components are GPLv2 or LGPLv2

What about something like this:

BY SETTING UP AND USING THIS SOFTWARE YOU ARE CONSENTING TO BE BOUND BY
THE TERMS OF THE LICENSES OF THE DIRECTORY SERVER AND OTHER COMPONENTS
USED BY THIS SOFTWARE.  THE LICENSES FOR DIRECTORY SERVER AND OTHER
COMPONENTS ARE FOUND IN FILES CALLED 'LICENSE' IN THE DOCUMENTATION
DIRECTORY FOR EACH COMPONENT.  IF YOU DO NOT AGREE TO ALL OF THE TERMS
OF THE LICENSES, PLEASE DO NOT SET UP OR USE THIS SOFTWARE.

Do you agree to the license terms? [no]:


Is this too cumbersome?

Comment 2 Nathan Kinder 2011-06-20 16:51:11 UTC
(In reply to comment #1)
> There are actually several different licenses
> directory server is GPLv2 + plugin exception
> admin server is mostly GPLv2 except for the Apache modules which are APL2
> the rest of the components are GPLv2 or LGPLv2
> 
> What about something like this:
> 
> BY SETTING UP AND USING THIS SOFTWARE YOU ARE CONSENTING TO BE BOUND BY
> THE TERMS OF THE LICENSES OF THE DIRECTORY SERVER AND OTHER COMPONENTS
> USED BY THIS SOFTWARE.  THE LICENSES FOR DIRECTORY SERVER AND OTHER
> COMPONENTS ARE FOUND IN FILES CALLED 'LICENSE' IN THE DOCUMENTATION
> DIRECTORY FOR EACH COMPONENT.  IF YOU DO NOT AGREE TO ALL OF THE TERMS
> OF THE LICENSES, PLEASE DO NOT SET UP OR USE THIS SOFTWARE.
> 
> Do you agree to the license terms? [no]:
> 
> 
> Is this too cumbersome?

I think that this is a good idea since there are different licenses for different components.

Comment 3 Rich Megginson 2011-06-20 18:18:54 UTC
Just spoke to Richard Fontana - according to him, we don't need to display or require the user to accept any EULA during setup.  So the right answer is to just get rid of this screen.

Comment 4 Rich Megginson 2011-06-20 19:11:39 UTC
Created attachment 505674 [details]
0001-Bug-703703-setup-ds-admin.pl-asks-for-legal-agreemen.patch

Comment 5 Rich Megginson 2011-06-20 20:10:29 UTC
To ssh://git.fedorahosted.org/git/389/ds.git
   2568704..c8e821c  master -> master
commit c8e821c11ec22c2b67cbaf0fa3f587778db223d9
Author: Rich Megginson <rmeggins>
Date:   Mon Jun 20 13:07:12 2011 -0600
    Reviewed by: nkinder (Thanks!)
    Branch: master
    Fix Description: According to the Red Hat Legal department, we do not need
    to display or ask the user to accept the EULA any more.  The EULA dialog
    and text has been removed.
    Platforms tested: RHEL6 x86_64
    Flag Day: no
    Doc impact: Yes - will need a slight amendment to the Install Guide.


Note You need to log in before you can comment on or make changes to this bug.