Created attachment 498247 [details]
Description of problem:
A reminder that the 'pre-release software' warning window should be removed before it's formally released, marked it as F15Blocker.
Version-Release number of selected component (if applicable):
The prerelease window is shown if the composes are made with isBeta flag enabled. This is not a bug. The window is there because it's still a prerelease.
Thanks Hurry ... I had a similar concern earlier this week. After talking to clumens, he confirmed what Martin indicated above. The correct change needed here is to have fedora-release updated.
That is planned by rel-eng and will be tracked in https://fedorahosted.org/rel-eng/ticket/4700
I just tested with the latest fedora-release package . It seems that isBeta=True is still set in /.buildstamp. Seems perhaps an additional lorax or pungi fix will be needed still to remove the betanag
I'd like to add whiteboard:AcceptedBlocker since this is clearly something we can't ship with, but I want to figure out how best to apply it to the criteria first.
Clumens is investigating, this may be fixed in pungi, or in lorax. I'm not yet clear on the ideal solution at this time.
In pungi's __init__.py lines 842-845... We need to get the is_beta value from somewhere (I don't know where) in pungi, and pass it to lorax.
# FIXME get the actual is_beta value
lorax.run(self.ayum, product=product, version=version,
variant=variant, bugurl=bugurl, is_beta=True,
Testing a pungi patch right now. Stand by.
Created attachment 498374 [details]
Add --isbeta flag
(In reply to comment #6)
> Testing a pungi patch right now. Stand by.
Using the supplied patch, the betanag does *not* appear.
While we don't have release criteria that explicitly note that the betanag must be removed, this is a high severity issue in pungi that results in a betanag for *all* users. I guarantee we'd have to respin to address this, and I wouldn't be comfortable releasing a product that had a "Warning, this is pre-release software" as the first screen.
Verified it fixed in F15-Final-RC1
(In reply to comment #9)
> Verified it fixed in F15-Final-RC1
Will mark as VERIFIED once there is an official fix posted to git (and packaged). Assigned to dgilmore for further handling.
dgilmore: Hi Dennis! I'd like to move this out of ASSIGNED if possible. I know you have a one-off change to address Final RC composes, is there a permanent fix for this in git already?
there is not yet a patch applied upstream, im going to work on one today
(In reply to comment #12)
> there is not yet a patch applied upstream, im going to work on one today
Hey Dennis, sorry to keep bugging on this one. Hoping to get this off our unresolved blocker list. Do you think we'll be able to move this out of ASSIGNED by the go/no_go meeting tomorrow (May 17 @ 17:00 EDT)?
Marking this as not a release blocker any more: per agreement at the go/no-go meeting today it is no longer blocking the release, as dgilmore patched it in RC3 compose. So it's still a bug until pungi is fixed, but it is not blocking F15.
Fedora Bugzappers volunteer triage team
Patch in git to address this issue for future releases ...
This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component.
This has long been fixed. and commited upstream