RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 703985 - Implementation issues found during Openswan code review for CCC evaluation
Summary: Implementation issues found during Openswan code review for CCC evaluation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: openswan
Version: 6.1
Hardware: Unspecified
OS: Unspecified
urgent
high
Target Milestone: rc
: ---
Assignee: Avesh Agarwal
QA Contact: BaseOS QE Security Team
URL:
Whiteboard:
Depends On:
Blocks: RHEL62CCC 712114 846801 846802
TreeView+ depends on / blocked
 
Reported: 2011-05-11 19:45 UTC by Avesh Agarwal
Modified: 2012-08-08 18:29 UTC (History)
6 users (show)

Fixed In Version: openswan-2.6.32-5.el6
Doc Type: Bug Fix
Doc Text:
Prior to this update, very large security label strings received from the peer were being truncated. The truncated string was then still used. However, this truncated string could, under rare circumstances, turn out to be a valid string, leading to an incorrect policy. Additionally, erroneous queuing of on-demand requests of setting up an IPsec connection was discovered in the IKEv2 (Internet Key Exchange) code. Although not harmful, it was not the intended design. This update fixes both of these issues, and Openswan now correctly handles the IKE setup.
Clone Of:
Environment:
Last Closed: 2011-12-06 19:05:24 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:1761 0 normal SHIPPED_LIVE openswan bug fix and enhancement update 2011-12-06 01:01:39 UTC

Description Avesh Agarwal 2011-05-11 19:45:33 UTC
Description of problem:
During the Openswan code review for CCC evaluation, there are 2 issues found upto now:

1. Labeled-ipsec code changes cause call to add_pending() in the function ikev2parent_outI1() in the file program/pluto/ikev2_parents.c to be out of HAS_IPSEC_POLICY(policy) check something unintended in the original code.
 
2. Very large security label strings received from the peer should not be truncated and should return false immediately leading to connection termination.


Version-Release number of selected component (if applicable):
openswan-2.6.32-el6


How reproducible:
Always

Steps to Reproduce:
1. code review.
2.
3.
  
Actual results:
The above stuff happens in the code.

Expected results:
The above stuff should not happen in the code.

Additional info:
I think that I am not sure how to test the above thing except from a code review again.

Comment 1 Avesh Agarwal 2011-05-11 19:47:12 UTC
The version is openswan-2.6.32-4.el6.

Comment 5 Martin Prpič 2011-07-13 19:42:20 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Prior to this update, very large security label strings received from the peer were being truncated. The truncated string was then still used. However, this truncated string could, under rare circumstances, turn out to be a valid string, leading to an incorrect policy. Additionally, erroneous queuing of on-demand requests of setting up an IPsec connection was discovered in the IKEv2 (Internet Key Exchange) code. Although not harmful, it was not the intended design. This update fixes both of these issues, and Openswan now correctly handles the IKE setup.

Comment 9 errata-xmlrpc 2011-12-06 19:05:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1761.html


Note You need to log in before you can comment on or make changes to this bug.