Spec URL: http://ueno.fedorapeople.org/recutils/recutils.spec SRPM URL: http://ueno.fedorapeople.org/recutils/recutils-1.3-1.fc15.src.rpm Description: Recutils is a set of tools and libraries to access human-editable, text-based databases called recfiles. The data is stored as a sequence of records, each record containing an arbitrary number of named fields.
The posted spec differs from the SRPM, which lacks the patch. But I found the current one, reviewing.
Build dies on F15: make[1]: Leaving directory `/home/limb/rpmbuild/BUILD/recutils-1.3' + '%{_emacs_bytecompile}' etc/rec-mode.el Looks like a dropped ?, should be %{?_emacs_bytecompile} But after fixing that: + etc/rec-mode.el /var/tmp/rpm-tmp.CTEadp: line 55: etc/rec-mode.el: Permission denied
Looks like you need to add BuildRequires: emacs-common to fix that. But then all the tests fail, killing the build.
(In reply to comment #3) > Looks like you need to add BuildRequires: emacs-common to fix that. Thanks for looking at this. Updated the spec and SRPM: Spec URL: http://ueno.fedorapeople.org/recutils/recutils.spec SRPM URL: http://ueno.fedorapeople.org/recutils/recutils-1.3-3.fc16.src.rpm > But then all the tests fail, killing the build. It seems that rpath setting in executables is necessary when running the test suite. I ended up keeping the rpath setting until %check and removing it in %install using chrpath.
SPEC and SRPM differ. Based on SRPM: This builds. :) Good: - rpmlint checks return: recutils.src: W: spelling-error Summary(en_US) recfile -> refile, rec file, rec-file The value of this tag appears to be misspelled. Please double-check. recutils.src: W: spelling-error %description -l en_US recfiles -> refiles, rec files, rec-files The value of this tag appears to be misspelled. Please double-check. Ignore. recutils.x86_64: W: invalid-url URL: http://www.gnu.org/software/recutils/ <urlopen error timed out> The value should be a valid, public HTTP, HTTPS, or FTP URL. Valid, but was slow in my browser tonight. recutils-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. recutils-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment The value of this tag appears to be misspelled. Please double-check. Ignore. recutils-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/librec.so.0.0.0 exit.5 This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation. recutils-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/librec.so.0.0.0 _exit.5 This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation. Can these be corrected? If so, is it upstreamable? recutils-libs.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. Not much to include here. - package meets naming guidelines - package meets packaging guidelines - license ( GPLv3+ ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Moc build to test BRs in progress.
BRs are good, just docs and exit().
(In reply to comment #5) > recutils-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/librec.so.0.0.0 > _exit.5 [...] > > Can these be corrected? If so, is it upstreamable? I think some of them could be easily corrected and upstreamable, but not entirely, for some reason: - some exit() call are in the code generated by flex - other exit() calls are in libgnu (gnulib), maintained in a separate upstream project For the time being I addressed the easy part only. Will ask the upstream later. > recutils-libs.x86_64: W: no-documentation > The package contains no documentation (README, doc, etc). You have to include > documentation files. > > Not much to include here. I merged -libs subpackage into the base package, so this warning should be removed now. Spec URL: http://ueno.fedorapeople.org/recutils/recutils.spec SRPM URL: http://ueno.fedorapeople.org/recutils/recutils-1.3-4.fc16.src.rpm
Ok. I was going to question the utility of merging -libs in, but the size difference is negligible. APPROVED.
Thanks for the review. New Package SCM Request ======================= Package Name: recutils Short Description: A set of tools to access GNU recfile databases Owners: ueno Branches: f16 f15 f14 InitialCC:
Git done (by process-git-requests).
recutils-1.3-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/recutils-1.3-4.fc15
recutils-1.3-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/recutils-1.3-4.fc14
recutils-1.3-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/recutils-1.3-4.fc16
recutils-1.4-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/recutils-1.4-1.fc16
recutils-1.4-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/recutils-1.4-1.fc15
recutils-1.4-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/recutils-1.4-1.fc14
recutils-1.4-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.
recutils-1.4-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.