Bug 704445 - Review Request: python-timelib - Parse english textual date descriptions
Summary: Review Request: python-timelib - Parse english textual date descriptions
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
Whiteboard: Stalled Submitter
Depends On:
TreeView+ depends on / blocked
Reported: 2011-05-13 07:40 UTC by PRABIN KUMAR DATTA
Modified: 2012-05-11 09:53 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2012-05-11 09:53:13 UTC
Type: ---

Attachments (Terms of Use)

Description PRABIN KUMAR DATTA 2011-05-13 07:40:17 UTC
Spec URL: http://prabindatta.fedorapeople.org/SPECS/python-timelib.spec
SRPM URL: http://prabindatta.fedorapeople.org/SRPMS/python-timelib-0.2.2-1.fc14.src.rpm
timelib is a short wrapper around php's internal timelib module.

Comment 1 PRABIN KUMAR DATTA 2011-05-13 07:48:14 UTC
Koji Build:

Runtime test:
[prabindatta@localhost ~]$ python
Python 2.7 (r27:82500, Sep 16 2010, 18:03:06) 
[GCC 4.5.1 20100907 (Red Hat 4.5.1-3)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import timelib
>>> timelib.strtodatetime('today')
datetime.datetime(2011, 5, 13, 0, 0)
>>> timelib.strtodatetime('next friday')
datetime.datetime(2011, 5, 20, 0, 0)
>>> timelib.strtodatetime('next monday')
datetime.datetime(2011, 5, 16, 0, 0)
>>> timelib.strtodatetime('29 feb 2008 -108 years')
datetime.datetime(1900, 3, 1, 0, 0)

>>> import time, timelib
>>> time.ctime(timelib.strtotime("now"))
'Fri May 13 12:09:59 2011'
>>> time.ctime(timelib.strtotime("4 hours ago"))
'Fri May 13 08:10:08 2011'
>>> time.ctime(timelib.strtotime("20080229 - 1 year"))
'Thu Mar  1 05:30:00 2007'

** This package is one the dependency package of "python-mwlib-0.12.14"

Comment 2 Fabian Affolter 2011-06-02 16:35:37 UTC
ext-date-lib is include in this package. This is not allowed according to the Fedora Packaging Guidelines [1]. Your description claims that this is just a wrapper for the PHP internal timelib module, so this module should be a BR or a runtime requirement.

[1] https://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries

Comment 3 PRABIN KUMAR DATTA 2011-06-02 18:59:40 UTC
 Here the ext-date-lib is not a prebuild-binary package and source code of ext-date-lib is attached with the timelib package by upstream.

"I am still in the basic level of package maintainer's level"

Can you kindly explain me why this is not allowed according to the
Fedora Packaging Guidelines?

Comment 4 PRABIN KUMAR DATTA 2011-06-02 19:23:23 UTC
On IRC channel #fedora-devel <gholms> has explained me.

I am sending a mail upstream with the hope that they will resolve this issue.

Comment 5 Fabian Affolter 2011-06-30 05:57:54 UTC
Any news from upstream?

Comment 6 PRABIN KUMAR DATTA 2011-06-30 23:19:55 UTC
Upstreams Reply:
no, sorry. that is IMHO the packager's job.

Currently, I don't have sufficient time to edit the code.

Comment 7 Matthias Runge 2012-03-24 19:00:48 UTC
Any progress here?

Note You need to log in before you can comment on or make changes to this bug.