Spec URL: http://www.grid.tsl.uu.se/review/nordugrid-arc-doc.spec
SRPM URL: http://www.grid.tsl.uu.se/review/nordugrid-arc-doc-1.0.1-1.fc14.src.rpm
This package contains the documentation for the nordugrid-arc package
See package review in Bug #530684.
- rpmlint checks return:
Insignificant spelling errors.
- package meets naming guidelines
- package meets packaging guidelines
- license (ASL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
So, nothing. Except, since there are no nordugrid RPMs in Fedora, I see no need for the Provides/Obsoletes you have there. Best to remove them to avoid bloating the yum metadata. Otherwise, it's good.
Honestly, the same goes for the main nordugrid-arc spec.
Pre-Fedora Provides/Obsoletes removed:
(I will do the same for the nordugrid-arc package before importing it in git.)
Many thanks for the review!
New Package SCM Request
Package Name: nordugrid-arc-doc
Short Description: Advanced Resource Connector Documentation
Branches: f14 f15 el5 el6
Git done (by process-git-requests).
nordugrid-arc-doc-1.0.2-1.fc14,nordugrid-arc-1.0.1-1.fc14 has been submitted as an update for Fedora 14.
nordugrid-arc-doc-1.0.2-1.el5,nordugrid-arc-1.0.1-1.el5 has been submitted as an update for Fedora EPEL 5.
nordugrid-arc-doc-1.0.2-1.fc15,nordugrid-arc-1.0.1-1.fc15 has been submitted as an update for Fedora 15.
nordugrid-arc-doc-1.0.2-1.el6,nordugrid-arc-1.0.1-1.el6.1 has been submitted as an update for Fedora EPEL 6.
nordugrid-arc-doc-1.0.2-1.fc14, nordugrid-arc-1.0.1-1.fc14 has been pushed to the Fedora 14 testing repository.
nordugrid-arc-doc-1.0.2-1.fc15, nordugrid-arc-1.0.1-1.fc15 has been pushed to the Fedora 15 stable repository.
nordugrid-arc-doc-1.0.2-1.fc14, nordugrid-arc-1.0.1-1.fc14 has been pushed to the Fedora 14 stable repository.
nordugrid-arc-doc-1.0.2-1.el5, nordugrid-arc-1.0.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository.
nordugrid-arc-doc-1.0.2-1.el6, nordugrid-arc-1.0.1-1.el6.1 has been pushed to the Fedora EPEL 6 stable repository.