Bug 705133 - Review Request: btparser - Parser and analyzer for backtraces produced by GDB
Summary: Review Request: btparser - Parser and analyzer for backtraces produced by GDB
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jiri Moskovcak
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-05-16 18:35 UTC by Karel Klíč
Modified: 2015-02-01 22:53 UTC (History)
5 users (show)

Fixed In Version: btparser-0.13-1.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-06-21 17:19:34 UTC
Type: ---
Embargoed:
jmoskovc: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Karel Klíč 2011-05-16 18:35:46 UTC
Spec URL: http://kklic.fedorapeople.org/btparser.spec
SRPM URL: http://kklic.fedorapeople.org/btparser-0.13-1.fc14.src.rpm
Description:
Btparser is a backtrace parser and analyzer, which works with
backtraces produced by the GNU Project Debugger. It can parse a text
file with a backtrace to a tree of C structures, allowing to analyze
the threads and frames of the backtrace and work with them.

Btparser also contains some backtrace manipulation and extraction
routines:
- it can find a frame in the crash-time backtrace where the program
  most likely crashed (a chance is that the function described in that
  frame is buggy)
- it can produce a duplication hash of the backtrace, which helps to
  discover that two crash-time backtraces are duplicates, triggered by
  the same flaw of the code
- it can "rate" the backtrace quality, which depends on the number of
  frames with and without the function name known (missing function
  name is caused by missing debugging symbols)

$ rpmlint btparser-0.13-1.fc14.src.rpm
btparser.src: W: spelling-error Summary(en_US) Backtrace -> Backtrack, Back trace, Back-trace
btparser.src: W: spelling-error Summary(en_US) backtraces -> backtracks, back traces, back-traces
btparser.src: W: spelling-error %description -l en_US backtrace -> backtrack, back trace, back-trace
btparser.src: W: spelling-error %description -l en_US backtraces -> backtracks, back traces, back-traces
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

-> Backtrace is a commonly used word. The word is used in the GDB and glibc manuals, and it is present in dictionaries.

$ rpmlint btparser-0.13-1.fc14.i386.rpm
btparser.i386: W: spelling-error Summary(en_US) Backtrace -> Backtrack, Back trace, Back-trace
btparser.i386: W: spelling-error Summary(en_US) backtraces -> backtracks, back traces, back-traces
btparser.i386: W: spelling-error %description -l en_US backtrace -> backtrack, back trace, back-trace
btparser.i386: W: spelling-error %description -l en_US backtraces -> backtracks, back traces, back-traces
btparser.i386: W: shared-lib-calls-exit /usr/lib/libbtparser.so.2.2.2 exit
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

-> The shared library calls function exit only when malloc fails because of some serious programming error.

$ rpmlint btparser-debuginfo-0.13-1.fc14.i386.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint btparser-devel-0.13-1.fc14.i386.rpm
btparser-devel.i386: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Comment 1 Jiri Moskovcak 2011-05-17 18:45:42 UTC
OK      source files match upstream:
 ca445ed4d8e40b75b8144dfe9bd66d3c6e0109c8  btparser-0.13.tar.xz
 ca445ed4d8e40b75b8144dfe9bd66d3c6e0109c8  btparser-local.tar.xz
OK      package meets naming and versioning guidelines.
OK      specfile is properly named, is cleanly written and uses macros consistently.
OK      dist tag is present.
OK      license field matches the actual license - GPLv2+
OK     license is open source-compatible. License text included in package - GPLv2+
OK     latest version is being packaged.
OK     BuildRequires are proper.
OK    compiler flags are appropriate.
OK      package builds in mock (F15).
OK      debuginfo package looks complete.
OK     rpmlint is silent. (just some false positives)

$ rpmlint SPECS/btparser.spec RPMS/x86_64/btparser-0.13-1.fc15.x86_64.rpm 
btparser.x86_64: W: spelling-error Summary(en_US) backtraces -> backtracks, back traces, back-traces
btparser.x86_64: W: spelling-error %description -l en_US backtrace -> backtrack, back trace, back-trace
btparser.x86_64: W: spelling-error %description -l en_US backtraces -> backtracks, back traces, back-traces
btparser.x86_64: W: shared-lib-calls-exit /usr/lib64/libbtparser.so.2.2.2 exit.5
-> explained in previous comment
1 packages and 1 specfiles checked; 0 errors, 4 warnings.

OK     final provides and requires look sane.
OK     %check is present and all tests pass.
OK      shared libraries are added to the regular linker search paths with
proper scriptlets
BAD      owns the directories it creates.

- %{_bindir}/%{name}
+ %dir %{_bindir}/%{name}

OK      doesn't own any directories it shouldn't.
OK      no duplicates in %files.
OK      file permissions are appropriate.
OK      correct scriptlets present.
N/A      documentation is small, so no -docs subpackage is necessary.
OK      %docs are not necessary for the proper functioning of the package.

- but packaging some offline reference manual would be nice

OK      headers in -devel
OK      pkgconfig files in -devel
OK      no libtool .la droppings.

- if you fix the %dir comment then I'm fine with it

Comment 2 Jiri Moskovcak 2011-05-17 18:49:06 UTC
My bad, it's not a directory. The rest seems ok.

Comment 3 Karel Klíč 2011-05-18 12:13:38 UTC
New Package SCM Request
=======================
Package Name: btparser
Short Description: Parser and analyzer for backtraces produced by GDB
Owners: kklic jmoskovc
Branches:
InitialCC:

Comment 4 Karel Klíč 2011-05-18 12:41:58 UTC
New Package SCM Request
=======================
Package Name: btparser
Short Description: Parser and analyzer for backtraces produced by GDB
Owners: kklic jmoskovc
Branches: f15
InitialCC:

Comment 5 Jason Tibbitts 2011-05-18 22:25:00 UTC
This ticket is not assigned to anyone.  It should be assigned to the reviewer.
Please fix and re-raise the fedora-cvs flag.

Comment 6 Jason Tibbitts 2011-05-19 16:25:27 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2011-06-07 15:01:57 UTC
btparser-0.13-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/btparser-0.13-1.fc15

Comment 8 Fedora Update System 2011-06-09 00:02:46 UTC
btparser-0.13-1.fc15 has been pushed to the Fedora 15 testing repository.

Comment 9 Fedora Update System 2011-06-21 17:19:29 UTC
btparser-0.13-1.fc15 has been pushed to the Fedora 15 stable repository.


Note You need to log in before you can comment on or make changes to this bug.