Description of problem: dasdinfo return 0 if action failed. Version-Release number of selected component (if applicable): s390utils-1.8.1-16.el5 How reproducible: always Steps to Reproduce: use dasdinfo in a wrong way, place wahtever string into block device [root@ibm-z10-32 /]# dasdinfo -b /dev/write_whatever_here -l Error: could not read unique DASD ID [root@ibm-z10-32 /]# echo $? 0 [root@ibm-z10-32 /]# dasdinfo -b /dev/write_whatever_here -u Error: could not read unique DASD ID [root@ibm-z10-32 /]# echo $? 0 [root@ibm-z10-32 /]# dasdinfo -b /dev/write_whatever_here -x Error: could not read unique DASD ID [root@ibm-z10-32 /]# echo $? 0 Actual results: return code = 0 Expected results: return code = 1 or more Additional info:
------- Comment From brueckner.ibm.com 2011-05-23 05:58 EDT------- The patch has been tested, fixes the problem, and will be included in the next upstream release of the s390-tools. With best regards, Hendrik
Created attachment 500383 [details] s390-tools-rhel5-dasdinfo-returncode.patch ------- Comment on attachment From brueckner.ibm.com 2011-05-23 05:58 EDT------- Description: dasdinfo: return error code in case of failure. Symptom: The dasdinfo tool always returns 0 even in case of an error. Problem: If the tool is used in a script the return code can not be used since it is always 0. Solution: Give a non zero return value in case of an error.
This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unfortunately unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux.
------- Comment From abdhalee.com 2012-01-03 05:21 EDT------- Hi, I tested it on RHEL5.8 S1, and the problem is fixed, now I am able to see proper return code. [root@h4215037 ~]# rpm -qa s390* s390utils-1.8.1-17.el5 [root@h4215037 ~]# uname -a Linux h4215037 2.6.18-301.el5 #1 SMP Tue Dec 13 16:55:37 EST 2011 s390x s390x s390x GNU/Linux [root@h4215037 ~]# dasdinfo -b /dev/write_whatever_here -l [root@h4215037 ~]# echo $? 255 Thanks for your support ! ------- Comment From abdhalee.com 2012-01-03 05:22 EDT------- closing this bugzilla as it is fixed.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2012-0243.html