Bug 706400 (libqzeitgeist) - Review Request: libqzeitgeist - Qt Zeitgeist Library
Summary: Review Request: libqzeitgeist - Qt Zeitgeist Library
Keywords:
Status: CLOSED ERRATA
Alias: libqzeitgeist
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Torrie Fischer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-05-20 13:06 UTC by Rex Dieter
Modified: 2011-06-04 02:57 UTC (History)
3 users (show)

Fixed In Version: libqzeitgeist-0.7.0-1.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-23 14:53:59 UTC
Type: ---
Embargoed:
tdfischer: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Comment 1 Rex Dieter 2011-05-20 13:08:12 UTC
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3083354

$ rpmlint *.rpm x86_64/*.rpm
libqzeitgeist-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 1 warnings.

Comment 2 Torrie Fischer 2011-05-20 13:17:22 UTC
I can review. Bonus: I'm upstream.

Comment 3 Rex Dieter 2011-05-20 13:20:05 UTC
f14 scratch build too:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3083374

Comment 4 Torrie Fischer 2011-05-20 13:38:16 UTC
> URL:     https://gitorious.org/kde-zeitgeist/libqzeitgeist
As a heads up, we've moved it to http://projects.kde.org/projects/kdesupport/libqzeitgeist. That can be fixed for next release though.

> BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

Your build root looks unusual to me, since it deviates from the one I'm used to seeing in /etc/rpmdevtools/spectemplate-lib.spec. I'm also still in the stone age and running fedora 14 ;)

Other than those two, its a quick and simple package and works like it says on the tin.

Approved.

Comment 5 Rex Dieter 2011-05-20 13:40:06 UTC
I guess an explicit buildroot is not needed on modern fedora systems, so I'll just drop that piece.

And, I'll update the URL prior to doing any official builds, thanks!

Comment 6 Rex Dieter 2011-05-20 13:46:08 UTC
New Package SCM Request
=======================
Package Name: libqzeitgeist
Short Description: Qt Zeitgeist Library
Owners: rdieter tdfischer
Branches: f14 f15
InitialCC:

Comment 7 Kevin Fenzi 2011-05-20 22:34:23 UTC
Git done (by process-git-requests).

Comment 8 Rex Dieter 2011-05-23 14:53:59 UTC
imported

Comment 9 Fedora Update System 2011-05-26 15:04:04 UTC
libqzeitgeist-0.7.0-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/libqzeitgeist-0.7.0-1.fc14

Comment 10 Fedora Update System 2011-05-26 15:04:29 UTC
libqzeitgeist-0.7.0-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/libqzeitgeist-0.7.0-1.fc15

Comment 11 Fedora Update System 2011-06-02 18:50:14 UTC
libqzeitgeist-0.7.0-1.fc15 has been pushed to the Fedora 15 stable repository.

Comment 12 Fedora Update System 2011-06-04 02:57:20 UTC
libqzeitgeist-0.7.0-1.fc14 has been pushed to the Fedora 14 stable repository.


Note You need to log in before you can comment on or make changes to this bug.