Red Hat Bugzilla – Bug 707078
obsolete (and uninitialized) variable ignore_schedd_limit is being used in place of ignore_submitter_limit
Last modified: 2011-09-07 12:41:18 EDT
Description of problem: the negotiate() function is being called with obsolete variable ignore_schedd_limit, which is uninitialized. It should be using ignore_submitter_limit. How reproducible: ignore_schedd_limit is uninitialized -- how reproducible is undetermined. Steps to Reproduce: NOTE: Should only ignore submitter limits on 1st spin of pie, and if considering preemption. Two possible repros: 1) false-pos (ignore submitter limits when shouldn't): ignoring limits when consider-preemption is false ignoring limits on spin-2 or higher 2) false-neg (should ignore submitter limits, but does not) obeying the limits on first spin, and when consider-preemption is true.
Upstream fix (7.7/master) https://condor-wiki.cs.wisc.edu/index.cgi/chngview?cn=21957 Attached to upstream ticket: https://condor-wiki.cs.wisc.edu/index.cgi/tktview?tn=2054,0
Fixed upstream on V7_6-branch.
The variable ignore_schedd_limit is not used anymore when the negotiate() function is invoked, and the correct ignore_submitter_limit is used instead. ignore_schedd_limit itself has been removed. Verified by source code inspection, condor-7.6.3-0.2 for RHEL5 and RHEL6.
Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: Cause: Inner negotiation loop called with an obsolete and uninitialized stack variable. Consequence: Depending on value of uninitialized stack memory, there is potential for either incorrectly ignoring submitter limits when limits should be respected, or conversely obeying submitter limits when they are expected to be ignored. Fix: Obsolete variable was removed and proper parameter to the inner negotiation loop was restored. Result: Guaranteed proper behavior regarding submitter limits is restored.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2011-1249.html