Bug 707295 - relativepath option in repo update
Summary: relativepath option in repo update
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Pulp
Classification: Retired
Component: z_other
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
unspecified
Target Milestone: ---
: Sprint 25
Assignee: Pradeep Kilambi
QA Contact: Preethi Thomas
URL:
Whiteboard:
Depends On:
Blocks: verified-to-close
TreeView+ depends on / blocked
 
Reported: 2011-05-24 16:03 UTC by Preethi Thomas
Modified: 2011-08-16 12:20 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-08-16 12:06:56 UTC
Embargoed:


Attachments (Terms of Use)

Description Preethi Thomas 2011-05-24 16:03:03 UTC
Description of problem.

Running repo update with --relativepath option always fails now since createrepo is being run at repo create time.  So the option needs to be removed from repo update.

Comment 1 Jeff Ortel 2011-05-25 16:03:28 UTC
Need to remove the --relativepath option from the CLI and the API class.  While we're there, let's make sure the --feed check is correct.  It needs to make sure the relative path is not changed.  We can also remove the code that checks to see if the repo has content.  Since the repo always has metadata, it's probably broken anyway.

Comment 2 Pradeep Kilambi 2011-06-17 14:42:30 UTC
commit 58b2e4aa2d8d95dcab7c33c867be00c5b7d0a473
Author: Pradeep Kilambi <pkilambi>
Date:   Fri Jun 17 10:40:45 2011 -0400

    707295 - removed relativepath from repo update; updated feed update logic to check if relative path matches before allowing update



$ sudo pulp-admin repo create --id=testrepo --feed=http://repos.fedorapeople.org/repos/pulp/pulp/demo_repos/test_bandwidth_repo/
Successfully created repository [ testrepo ]

$ sudo pulp-admin repo update --feed=http://repos.fedorapeople.org/repos/pulp/pulp/demo_repos/test_bandwidth_repo/ --id=testrepo
Successfully updated repository [ testrepo ]

$ sudo pulp-admin repo update --feed=http://repos.fedorapeople.org/repos/pulp/pulp/demo_repos/test_bandwidth_repo/fake/ --id=testrepo
error: operation failed: PulpException: u'Relativepath of the new feed [repos/pulp/pulp/demo_repos/test_bandwidth_repo/fake] does not match existing feed [repos/pulp/pulp/demo_repos/test_bandwidth_repo]; cannot perform update'

Comment 3 Jeff Ortel 2011-06-17 21:10:11 UTC
build: 0.192

Comment 4 Preethi Thomas 2011-07-07 16:20:33 UTC
[root@preethi ~]# rpm -q pulp
pulp-0.0.202-1.fc14.noarch

[root@preethi ~]# pulp-admin repo create --id=testrepo --feed=http://repos.fedorapeople.org/repos/pulp/pulp/demo_repos/test_bandwidth_repo/
Successfully created repository [ testrepo ]

[root@preethi ~]# pulp-admin repo update --id=testrepo --feed=http://repos.fedorapeople.org/repos/pulp/pulp/demo_repos/test_bandwidth_repo/
Successfully updated repository [ testrepo ]

[root@preethi ~]# pulp-admin repo update --id=testrepo --feed=http://repos.fedorapeople.org/repos/pulp/pulp/demo_repos/test_bandwidth_repo/fake/
error: operation failed: PulpException: u'Relativepath of the new feed [repos/pulp/pulp/demo_repos/test_bandwidth_repo/fake] does not match existing feed [repos/pulp/pulp/demo_repos/test_bandwidth_repo]; cannot perform update'
[root@preethi ~]#

Comment 5 Preethi Thomas 2011-08-16 12:06:56 UTC
Closing with Community Release 15

pulp-0.0.223-4.

Comment 6 Preethi Thomas 2011-08-16 12:20:49 UTC
Closing with Community Release 15

pulp-0.0.223-4.


Note You need to log in before you can comment on or make changes to this bug.