Spec URL: http://people.redhat.com/vondruch/rubygem-bson.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-bson-1.3.1-1.fc16.src.rpm Description: A Ruby BSON implementation for MongoDB. For more information about Mongo, see http://www.mongodb.org. For more information on BSON, see http://www.bsonspec.org. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3093292
My fist rubygem review, so be patient. I suppose it's okay to define also other paths in 'gem install' than those stated in guidelines. -> --bindir .%{_bindir} You don't own: %{gemdir}/gems/%{gemname}-%{version}/ ,which you should own according guidelines. Rpmlint is complaining. rpmlint rubygem-bson-1.3.1-1.fc16.src.rpm rubygem-bson.src: W: invalid-url Source1: bson-tests.tgz rubygem-bson.noarch: W: no-documentation rubygem-bson.noarch: W: no-manual-page-for-binary b2json rubygem-bson.noarch: W: no-manual-page-for-binary j2bson
(In reply to comment #1) > My fist rubygem review, so be patient. > > I suppose it's okay to define also other paths in 'gem install' than those > stated in guidelines. -> --bindir .%{_bindir} This avoids struggle with moving binaries and setting execution bits etc, so it is the recommended approach. > > You don't own: %{gemdir}/gems/%{gemname}-%{version}/ ,which you should own > according guidelines. I own %{geminstdir} which is the same I hope > > Rpmlint is complaining. > rpmlint rubygem-bson-1.3.1-1.fc16.src.rpm > rubygem-bson.src: W: invalid-url Source1: bson-tests.tgz This is custom archive with files necessary to execute the test suite. > rubygem-bson.noarch: W: no-documentation Documentation is in subpackage. > rubygem-bson.noarch: W: no-manual-page-for-binary b2json > rubygem-bson.noarch: W: no-manual-page-for-binary j2bson No manual pages. It is not common for rubygems to contains manual pages :/
(In reply to comment #2) > (In reply to comment #1) > > My fist rubygem review, so be patient. > > > > I suppose it's okay to define also other paths in 'gem install' than those > > stated in guidelines. -> --bindir .%{_bindir} > > This avoids struggle with moving binaries and setting execution bits etc, so it > is the recommended approach. > > > > > You don't own: %{gemdir}/gems/%{gemname}-%{version}/ ,which you should own > > according guidelines. > > I own %{geminstdir} which is the same I hope > Should be fixed in packaging guidelines. > > > > > Rpmlint is complaining. > > rpmlint rubygem-bson-1.3.1-1.fc16.src.rpm > > rubygem-bson.src: W: invalid-url Source1: bson-tests.tgz > > This is custom archive with files necessary to execute the test suite. > Ok, but it's ugly. > > rubygem-bson.noarch: W: no-documentation > > Documentation is in subpackage. > > > rubygem-bson.noarch: W: no-manual-page-for-binary b2json > > rubygem-bson.noarch: W: no-manual-page-for-binary j2bson > > No manual pages. It is not common for rubygems to contains manual pages :/ resolvedeps-f16 ~/Downloads/rubygem-bson-1.3.1-1.fc16.noarch.rpm Binary dependencies resolvable. Ok. APPROVED
(In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > My fist rubygem review, so be patient. > > > > > > I suppose it's okay to define also other paths in 'gem install' than those > > > stated in guidelines. -> --bindir .%{_bindir} > > > > This avoids struggle with moving binaries and setting execution bits etc, so it > > is the recommended approach. > > > > > > > > You don't own: %{gemdir}/gems/%{gemname}-%{version}/ ,which you should own > > > according guidelines. > > > > I own %{geminstdir} which is the same I hope > > > Should be fixed in packaging guidelines. Agree :) > > > > > > > > Rpmlint is complaining. > > > rpmlint rubygem-bson-1.3.1-1.fc16.src.rpm > > > rubygem-bson.src: W: invalid-url Source1: bson-tests.tgz > > > > This is custom archive with files necessary to execute the test suite. > > > Ok, but it's ugly. Agree. If you know some better way ... > > > > rubygem-bson.noarch: W: no-documentation > > > > Documentation is in subpackage. > > > > > rubygem-bson.noarch: W: no-manual-page-for-binary b2json > > > rubygem-bson.noarch: W: no-manual-page-for-binary j2bson > > > > No manual pages. It is not common for rubygems to contains manual pages :/ > > resolvedeps-f16 ~/Downloads/rubygem-bson-1.3.1-1.fc16.noarch.rpm > Binary dependencies resolvable. Ok. > > APPROVED Thank you for your review. New Package SCM Request ======================= Package Name: rubygem-bson Short Description: Ruby implementation of BSON Owners: vondruch Branches: InitialCC:
Git done (by process-git-requests).