Description of problem:

rwhod receives but doesn't transmit reliably if using DHCP (eg: via NetworkManager)

Version-Release number of selected component (if applicable):

rwho-0.17-33.fc14.x86_64


How reproducible:

Easy, but its a race condition.

Steps to Reproduce:
1. start system
2. wait 5 minutes, then do 'ruptime' on another system
3. note your system isn't showing as up (or at all possibly)
  
Actual results:

not up or missing in ruptime output

Expected results:

system up in ruptime output

Additional info:


When DHCP is in use, the UP interface list may not be finalized by
the time rwhod starts, and rwhod only scans the interface list at
startup.

The following patch addresses this by scanning the interface list
every time just prior to transmitting new information, allowing
the network details to change completely since the previous transmission.

--
*** rwhod.c_pre Sat May 28 00:11:51 2011
--- rwhod.c     Sat May 28 00:12:15 2011
***************
*** 383,388 ****
--- 383,390 ----
        getboottime(&mywd);
  
        while (1) {
+               if (!configure(sk))
+                       exit(1);
                sendpacket(&mywd);
                (void) sleep(AL_INTERVAL);
        }
***************
*** 603,608 ****
--- 605,624 ----
        struct sockaddr_in *sn;
        register struct neighbor *np;
  
+       /* forget previous neighbors; interfaces may have changed */
+       for (np = neighbors; np != NULL; ) {
+               register struct neighbor *pp;
+ 
+               if(np->n_name)
+                       free(np->n_name);
+               if(np->n_addr)
+                       free(np->n_addr);
+               pp = np;
+               np = np->n_next;
+               free((char *)pp);
+       }
+       neighbors = 0;
+ 
        ifc.ifc_len = sizeof (buf);
        ifc.ifc_buf = (char *)buf;
        if (ioctl(s, SIOCGIFCONF, &ifc) < 0) {


--