Bug 708664 - Review Request: jp2a - an utility for converting JPEG images to ASCII
Summary: Review Request: jp2a - an utility for converting JPEG images to ASCII
Keywords:
Status: CLOSED DUPLICATE of bug 1462466
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-05-28 18:06 UTC by Andres
Modified: 2017-06-17 21:22 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-01-18 16:22:48 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Andres 2011-05-28 18:06:06 UTC
Spec URL: http://morpheusv.fedorapeople.org/jp2a.spec
SRPM URL: http://morpheusv.fedorapeople.org/jp2a-1.0.6-1.fc15.src.rpm
Description: 
jp2a is a small command-line utility for converting JPEG images
to ASCII art.

Comment 1 Yanchuan Nian 2011-05-30 15:13:25 UTC
Hi Andres,
There are some problems with your package.
(1)There is only one percent sign in your comment, but macros are expanded first,
so you need to double it.See here:
https://fedoraproject.org/wiki/How_to_create_an_RPM_package
(2)The license must be specific instead of just "GPL".
(3)The summary doesn't begin with a capital letter.
Maybe you need run rpmlint first.

Comment 2 Andres 2011-06-03 11:10:28 UTC
thanks for making observations, You can find the new spec at 

http://morpheusv.fedorapeople.org/jp2a/1.0.6-2/jp2a.spec
http://morpheusv.fedorapeople.org/jp2a/1.0.6-2/jp2a-1.0.6-2.fc15.src.rpm

this is a result the rpmlint SPECS/jp2a.spec:
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 3 Itamar Reis Peixoto 2011-06-03 14:58:07 UTC
you're already sponsored by toshio at fudcon-panama , removing 	FE-NEEDSPONSOR

Comment 4 Itamar Reis Peixoto 2011-06-03 18:07:05 UTC
Can you post here a link to a koji scratch build ?

Comment 5 Andres 2011-06-04 23:16:36 UTC
this is the link  koji scratch build :  http://koji.fedoraproject.org/koji/taskinfo?taskID=3111554

Comment 6 Itamar Reis Peixoto 2011-06-05 13:11:12 UTC
look at buildlog, I think  BuildRequires is missing for curl-devel and ncurses-devel


checking for curl-config... no
checking for curl_easy_init in -lcurl... no
configure: WARNING: I need a working libcurl (use --with-curl-config=PATH); download-support will be disabled


checking for tgetent in -lterminfo... no
configure: WARNING: probably need a terminal library, one of: ncurses curses termlib termcap terminfo

Comment 7 Andres 2011-06-12 02:44:14 UTC
has built libcurl-devel.
It has been tested to install and uninstall the package in a test in a PC and has been installed successfully.

you can find the new spec at:
http://morpheusv.fedorapeople.org/jp2a/1.0.6-3/jp2a.spec
http://morpheusv.fedorapeople.org/jp2a/1.0.6-3/jp2a-1.0.6-3.fc15.src.rpm

this is the link  koji scratch build : 
http://koji.fedoraproject.org/koji/taskinfo?taskID=3126525

I'll watch for comments or approval.

Comment 8 Itamar Reis Peixoto 2011-06-16 05:38:31 UTC
I still see the warning about curl 

http://koji.fedoraproject.org/koji/getfile?taskID=3126526&name=build.log

configure: WARNING: probably need a terminal library, one of: ncurses curses termlib termcap terminfo

Comment 9 Itamar Reis Peixoto 2011-06-16 05:39:42 UTC
I use macros in this way
%{name}-%{version}

Comment 10 Martin Gieseking 2011-07-28 19:21:42 UTC
Some more notes:

- I agree, BR ncurses-devel is missing and should be added. It's required to
  get the current terminal size. Without it, default values are used.

- Adapt Source0 according to 
  http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net

- Choose a more appropriate Group, e.g. Applications/Text

- Add file COPYING to the package.

- Be a bit more specific in %files, i.e. replace 
  %{_mandir}/man1/* with %{_mandir}/man1/%{name}.1*

Comment 11 Mario Blättermann 2012-07-29 11:19:11 UTC
Is there any progress in this review? Andres, are you still interested in to maintain this package?

Comment 12 Andres 2012-07-30 15:01:48 UTC
(In reply to comment #11)
> Is there any progress in this review? Andres, are you still interested in to
> maintain this package?

Sure you can, I am still interested in keeping the package. Soon I'll upload the new revision.

Comment 13 Mario Blättermann 2012-09-06 07:35:05 UTC
Any progress in the meantime? If you provide new files, I will do the review.

Comment 14 Mario Blättermann 2012-10-06 15:59:27 UTC
Two months after your last answer... Any news? If not, it would be time to close this as FE-DEADREVIEW.

Comment 15 fszymanski 2016-10-28 08:46:51 UTC
Spec URL: https://fszymanski.fedorapeople.org/jp2a/jp2a.spec
SRPM URL: https://fszymanski.fedorapeople.org/jp2a/jp2a-1.0.7-1.fc24.src.rpm

Scratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=16237643
COPR: http://copr.fedorainfracloud.org/coprs/fszymanski/jp2a/

Fedora Account System Username: fszymanski

Hi guys,
I would like to pick up this package (if it's possible).

Comment 16 Raphael Groner 2017-06-17 21:22:55 UTC

*** This bug has been marked as a duplicate of bug 1462466 ***


Note You need to log in before you can comment on or make changes to this bug.