Spec URL: http://morpheusv.fedorapeople.org/jp2a.spec SRPM URL: http://morpheusv.fedorapeople.org/jp2a-1.0.6-1.fc15.src.rpm Description: jp2a is a small command-line utility for converting JPEG images to ASCII art.
Hi Andres, There are some problems with your package. (1)There is only one percent sign in your comment, but macros are expanded first, so you need to double it.See here: https://fedoraproject.org/wiki/How_to_create_an_RPM_package (2)The license must be specific instead of just "GPL". (3)The summary doesn't begin with a capital letter. Maybe you need run rpmlint first.
thanks for making observations, You can find the new spec at http://morpheusv.fedorapeople.org/jp2a/1.0.6-2/jp2a.spec http://morpheusv.fedorapeople.org/jp2a/1.0.6-2/jp2a-1.0.6-2.fc15.src.rpm this is a result the rpmlint SPECS/jp2a.spec: 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
you're already sponsored by toshio at fudcon-panama , removing FE-NEEDSPONSOR
Can you post here a link to a koji scratch build ?
this is the link koji scratch build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3111554
look at buildlog, I think BuildRequires is missing for curl-devel and ncurses-devel checking for curl-config... no checking for curl_easy_init in -lcurl... no configure: WARNING: I need a working libcurl (use --with-curl-config=PATH); download-support will be disabled checking for tgetent in -lterminfo... no configure: WARNING: probably need a terminal library, one of: ncurses curses termlib termcap terminfo
has built libcurl-devel. It has been tested to install and uninstall the package in a test in a PC and has been installed successfully. you can find the new spec at: http://morpheusv.fedorapeople.org/jp2a/1.0.6-3/jp2a.spec http://morpheusv.fedorapeople.org/jp2a/1.0.6-3/jp2a-1.0.6-3.fc15.src.rpm this is the link koji scratch build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3126525 I'll watch for comments or approval.
I still see the warning about curl http://koji.fedoraproject.org/koji/getfile?taskID=3126526&name=build.log configure: WARNING: probably need a terminal library, one of: ncurses curses termlib termcap terminfo
I use macros in this way %{name}-%{version}
Some more notes: - I agree, BR ncurses-devel is missing and should be added. It's required to get the current terminal size. Without it, default values are used. - Adapt Source0 according to http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net - Choose a more appropriate Group, e.g. Applications/Text - Add file COPYING to the package. - Be a bit more specific in %files, i.e. replace %{_mandir}/man1/* with %{_mandir}/man1/%{name}.1*
Is there any progress in this review? Andres, are you still interested in to maintain this package?
(In reply to comment #11) > Is there any progress in this review? Andres, are you still interested in to > maintain this package? Sure you can, I am still interested in keeping the package. Soon I'll upload the new revision.
Any progress in the meantime? If you provide new files, I will do the review.
Two months after your last answer... Any news? If not, it would be time to close this as FE-DEADREVIEW.
Spec URL: https://fszymanski.fedorapeople.org/jp2a/jp2a.spec SRPM URL: https://fszymanski.fedorapeople.org/jp2a/jp2a-1.0.7-1.fc24.src.rpm Scratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=16237643 COPR: http://copr.fedorainfracloud.org/coprs/fszymanski/jp2a/ Fedora Account System Username: fszymanski Hi guys, I would like to pick up this package (if it's possible).
*** This bug has been marked as a duplicate of bug 1462466 ***