Created attachment 501603 [details]
logs

Description of problem:

if umount fails during domain create the storage will be created but user will not be able to use it. 
the domain will be created and a "can't find master storage domain" error will also be sent. 



Version-Release number of selected component (if applicable):

vdsm-4.9-70.el6.x86_64
libvirt-0.8.7-18.el6.x86_64

How reproducible:


Steps to Reproduce:
1. fail umount during SD create
2.
3.
  
Actual results:

the storage domain will remain mounted and allthough SD will be successfully created the user will get "can't find master domain" error  and storage will not be usable. 


Expected results:

we should be able to handle cases where umount fails during creating of SD

Additional info: full logs attached

Thread-542::ERROR::2011-05-29 14:52:54,852::sp::344::Storage.StoragePool::(create) Create domain canceled due to an unexpected error
Traceback (most recent call last):
  File "/usr/share/vdsm/storage/sp.py", line 327, in create
    self.createMaster(poolName, msd, masterVersion, safeLease)
  File "/usr/share/vdsm/storage/sp.py", line 500, in createMaster
    domain.unmountMaster()
  File "/usr/share/vdsm/storage/blockSD.py", line 893, in unmountMaster
    self.doUnmountMaster(masterdir)
  File "/usr/share/vdsm/storage/blockSD.py", line 886, in doUnmountMaster
    raise se.StorageDomainMasterUnmountError(masterdir, rc)
StorageDomainMasterUnmountError: Error unmounting master storage domain: 'masterdir=/rhev/data-center/mnt/blockSD/e6cae5cc-65fa-411c-a7f7-27f600e13da0/master, rc=1'
Thread-542::INFO::2011-05-29 14:52:54,868::sp::743::Storage.StoragePool::(detachSD) sdUUID=<storage.blockSD.BlockStorageDomain instance at 0x7ff23c238fc8> spUUID=bb0c60f3-0df2-4305-a81e-e0df186bfab7 msdUUID=e6cae5cc-65fa-411c-a7f7-27f600e13da0



Thread-542::ERROR::2011-05-29 14:52:57,374::sp::1169::Storage.StoragePool::(getMasterDomain) Couldn't find master domain for pool bb0c60f3-0df2-4305-a81e-e0df186bfab7
Traceback (most recent call last):
  File "/usr/share/vdsm/storage/sp.py", line 190, in __cleanupDomains
    self.detachSD(d, msdUUID, masterVersion)
  File "/usr/share/vdsm/storage/sp.py", line 745, in detachSD
    dom = SDF.produce(sdUUID)
  File "/usr/share/vdsm/storage/sdf.py", line 32, in produce
    raise se.StorageDomainDoesNotExist(sdUUID)
StorageDomainDoesNotExist: Storage domain does not exist: (<storage.blockSD.BlockStorageDomain instance at 0x7ff23c238fc8>,)
Thread-542::ERROR::2011-05-29 14:52:57,374::sp::350::Storage.StoragePool::(create) Cleanup failed due to an unexpected error
Traceback (most recent call last):
  File "/usr/share/vdsm/storage/sp.py", line 348, in create
    self.__cleanupDomains(domList, msdUUID, masterVersion)
  File "/usr/share/vdsm/storage/sp.py", line 193, in __cleanupDomains
    self.refresh()
  File "/usr/share/vdsm/storage/sp.py", line 960, in refresh
    self.__rebuild(msdUUID=msdUUID, masterVersion=masterVersion)
  File "/usr/share/vdsm/storage/sp.py", line 906, in __rebuild
    msdUUID = self.getMasterDomain(msdUUID=msdUUID, masterVersion=masterVersion).sdUUID
  File "/usr/share/vdsm/storage/sp.py", line 1170, in getMasterDomain
    raise se.StoragePoolMasterNotFound(self.spUUID, str(msdUUID))
StoragePoolMasterNotFound: Cannot find master domain: 'spUUID=bb0c60f3-0df2-4305-a81e-e0df186bfab7, msdUUID=None'
Thread-542::INFO::2011-05-29 14:52:57,375::safelease::83::ClusterLock::(release) Releasing cluster lock for domain e6cae5cc-65fa-411c-a7f7-27f600e13da0
Thread-542::DEBUG::2011-05-29 14:52:57,375::safelease::84::Storage.Misc.excCmd::(release) '/usr/libexec/vdsm/spmstop.sh e6cae5cc-65fa-411c-a7f7-27f600e13da0' (cwd /usr/libexec/vdsm/)