Bug 708838 - glines board doesn't refresh
Summary: glines board doesn't refresh
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-games
Version: 15
Hardware: i686
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Ray Strode [halfline]
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-05-29 20:04 UTC by Ben Asselstine
Modified: 2011-07-20 19:57 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2011-07-20 19:57:59 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
white boxes remaining behind after glines moves (598.23 KB, video/ogg)
2011-05-29 20:04 UTC, Ben Asselstine
no flags Details
only show white box outlines when we're supposed to show them (1.29 KB, patch)
2011-07-17 14:31 UTC, Ben Asselstine
no flags Details | Diff

Description Ben Asselstine 2011-05-29 20:04:26 UTC
Created attachment 501651 [details]
white boxes remaining behind after glines moves

Description of problem:

Five Or More leaves box-outlines behind after a move.  

Version-Release number of selected component (if applicable):

3.0.1.1

How reproducible:
Easily reproduced.  It happens 100% of the time.

Steps to Reproduce:
1. Start a new game.
2. Click a ball with the mouse.
3. Click on an empty destination square with the mouse.
  
Actual results:
The ball moves to the destination square, and a white box appears around the destination square.

Expected results:
The ball moves to the destination square.

The white box shouldn't be shown at all.  In previous versions the white box was used only when keyboard arrow-keys+enter were used.

Additional info:

The board gets redrawn when a line is completed, so some of the white boxes go away.

I have fast moves turned on, and a non-standard background colour set in preferences.

I have attached a video of the bug in action.

Comment 1 Ben Asselstine 2011-07-17 14:31:22 UTC
Created attachment 513525 [details]
only show white box outlines when we're supposed to show them

Comment 2 Ben Asselstine 2011-07-17 14:40:41 UTC
The white boxes that can sometimes outline a square get enabled when the arrow keys are used, and they go away when the mouse is used to click a ball.

The preceding patch fixes the problem of many white boxes hanging around.
It also fixes the problem of white boxes showing up when I click on a ball.  

I haven't done the bug-research to find out why the white boxes suddenly showed up when using a mouse, so fixing this may cause a regression for somebody else.

Please commit this patch.

Comment 3 Ben Asselstine 2011-07-20 19:57:59 UTC
Fixed upstream at:
https://bugzilla.gnome.org/show_bug.cgi?id=651870


Note You need to log in before you can comment on or make changes to this bug.