Bug 709327 - hivex cannot read registry hives from ReactOS
Summary: hivex cannot read registry hives from ReactOS
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: hivex
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Maros Zatko
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 709326
TreeView+ depends on / blocked
 
Reported: 2011-05-31 12:03 UTC by Richard W.M. Jones
Modified: 2015-02-18 13:34 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-02-18 13:34:02 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Debug output from this command: echo ls | hivexsh -d SOFTWARE (5.05 KB, text/plain)
2011-05-31 12:08 UTC, Richard W.M. Jones
no flags Details

Description Richard W.M. Jones 2011-05-31 12:03:04 UTC
Description of problem:

Hivex cannot read any of the hives from a fresh ReactOS
install.  In each case, trying to list the children of
the root nodes returns EFAULT, indicating that it is
trying to follow a pointer that points outside the registry.

Version-Release number of selected component (if applicable):

hivex-1.2.7-3.fc16.x86_64

How reproducible:

Always.

Steps to Reproduce:
1. Install ReactOS.
2. Download contents of /reactos/system32/config
3. Try to use (eg.) hivexregedit to list the contents.
  
Actual results:

$ hivexsh SOFTWARE

Welcome to hivexsh, the hivex interactive shell for examining
Windows Registry binary hive files.

Type: 'help' for help summary
      'quit' to quit the shell

SOFTWARE\> help
Navigate through the hive's keys using the 'cd' command, as if it
contained a filesystem, and use 'ls' to list the subkeys of the
current key.  Full documentation is in the hivexsh(1) manual page.
SOFTWARE\> ls
ls: Bad address

Expected results:


Additional info:

Comment 1 Richard W.M. Jones 2011-05-31 12:08:35 UTC
Created attachment 501981 [details]
Debug output from this command: echo ls | hivexsh -d SOFTWARE

Comment 2 Richard W.M. Jones 2011-05-31 14:03:26 UTC
I raised this issue on the ReactOS developers mailing list[1]
and also looked into the code.  It does appear to be a bug
in ReactOS not setting that field.  However the fix is not
very trivial.

Any fix would start with this patch:

Index: hivedata.h
===================================================================
--- hivedata.h  (revision 52019)
+++ hivedata.h  (working copy)
@@ -143,7 +143,9 @@
       If the hive is volatile, this is the actual pointer to the CM_KEY_NODE */
    HCELL_INDEX RootCell;
 
-   /* Size of each hive block ? */
+   /* Length of meaningful data in the file, excluding base block.
+      The file itself can be longer than this, but Windows will ignore
+      anything after. */
    ULONG Length;
 
    /* (1?) */

[1] http://www.reactos.org/archives/public/ros-dev/2011-May/thread.html

Comment 3 Fedora End Of Life 2013-04-03 17:21:36 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 4 Fedora End Of Life 2015-01-09 16:41:08 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Maros Zatko 2015-02-12 15:18:58 UTC
I've tried it with ReactOS 0.4 official qemu image and it seems to be fixed.

Comment 6 Fedora End Of Life 2015-02-18 13:34:02 UTC
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.