Hide Forgot
Version-Release number of selected component (if applicable): libguestfs-1.7.17-17.el6 Steps to Reproduce: 1. rpmbuild --define '__patch /bin/true' --rebuild libguestfs-1.7.17-17.el6.src.rpm Actual results: + chmod +x regressions/test-guestfish-tilde.sh chmod: cannot access `regressions/test-guestfish-tilde.sh': No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.fDpYWh (%prep) Additional info: The proposed change is required for Coverity to scan defects in downstream patches separately.
Created attachment 502134 [details] proposed fix
dev-ack for 6.2.
I'm changing my mind on this after trying to make a spec file which conditionally builds without patches. This change would make the spec file more complex and fragile, and I just don't understand the gain from doing this. We already run Coverity upstream on libguestfs and we already include fixes upstream for bugs that Coverity finds. Furthermore, libguestfs in RHEL 6 is very close to upstream. There are only about 5 patches specific to RHEL. If Coverity finds a bug in the RHEL 6 package (with all the patches) then it is highly likely that it's also a bug for upstream, and either way we want to hear about it. Please report it in BZ or to our upstream mailing list.
Development Management has reviewed and declined this request. You may appeal this decision by reopening this request.
(In reply to comment #7) > The patch doesn't apply. Indeed. You did not tell the patch did not apply (and I did not realize you had completely changed the way you apply patches in a minor RHEL update). Then the reject makes sense, of course.