Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 709538

Summary: fails to build without downstream patches
Product: Red Hat Enterprise Linux 6 Reporter: Kamil Dudka <kdudka>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED WONTFIX QA Contact: Virtualization Bugs <virt-bugs>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 6.1CC: leiwang
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-08-10 12:35:08 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
proposed fix none

Description Kamil Dudka 2011-05-31 23:24:55 UTC
Version-Release number of selected component (if applicable):
libguestfs-1.7.17-17.el6


Steps to Reproduce:
1. rpmbuild --define '__patch /bin/true' --rebuild libguestfs-1.7.17-17.el6.src.rpm

  
Actual results:
+ chmod +x regressions/test-guestfish-tilde.sh
chmod: cannot access `regressions/test-guestfish-tilde.sh': No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.fDpYWh (%prep)


Additional info:
The proposed change is required for Coverity to scan defects in downstream
patches separately.

Comment 1 Kamil Dudka 2011-05-31 23:25:51 UTC
Created attachment 502134 [details]
proposed fix

Comment 3 Richard W.M. Jones 2011-06-10 10:04:43 UTC
dev-ack for 6.2.

Comment 4 Richard W.M. Jones 2011-08-10 12:20:43 UTC
I'm changing my mind on this after trying to make a spec
file which conditionally builds without patches.

This change would make the spec file more complex
and fragile, and I just don't understand the gain from
doing this.  We already run Coverity upstream on libguestfs
and we already include fixes upstream for bugs that Coverity
finds.

Furthermore, libguestfs in RHEL 6 is very close to upstream.
There are only about 5 patches specific to RHEL.  If Coverity
finds a bug in the RHEL 6 package (with all the patches)
then it is highly likely that it's also a bug for upstream,
and either way we want to hear about it.  Please report it
in BZ or to our upstream mailing list.

Comment 5 RHEL Program Management 2011-08-10 12:35:08 UTC
Development Management has reviewed and declined this request.  You may appeal
this decision by reopening this request.

Comment 8 Kamil Dudka 2011-08-10 15:21:18 UTC
(In reply to comment #7)
> The patch doesn't apply.

Indeed.  You did not tell the patch did not apply (and I did not realize you had completely changed the way you apply patches in a minor RHEL update).  Then the reject makes sense, of course.