Bug 710387 - Review Request: gnome-shell-extension-presentation-mode - A gnome-shell extension to control the screensaver
Summary: Review Request: gnome-shell-extension-presentation-mode - A gnome-shell exten...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Clint Savage
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-03 09:44 UTC by Fabian Affolter
Modified: 2011-06-15 18:30 UTC (History)
5 users (show)

Fixed In Version: gnome-shell-extension-presentation-mode-0-0.2.gitc3ce6b2.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-06-15 18:30:08 UTC
Type: ---
Embargoed:
herlo1: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Fabian Affolter 2011-06-03 09:44:44 UTC
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gnome-shell-extensions-presentation-mode.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gnome-shell-extensions-presentation-mode-0-0.1.git89577dc.fc15.src.rpm

Project URL: https://github.com/RaphaelKimmig/Gnome-Presentation-Mode

Description:
Gnome-Presentation-Mode is a tiny gnome-shell extension that adds a new
entry to the power indicator (the menu that opens when you click the
battery icon).  While presentation mode is on the screensaver and the
automatic suspend will not kick in, allowing you to sit back and enjoy
whatever you are doing without having to wiggle the mouse every few
minutes.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3107795

rpmlint output:
[fab@laptop021 SRPMS]$ rpmlint gnome-shell-extensions-presentation-mode*
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[fab@laptop021 noarch]$ rpmlint gnome-shell-extensions-presentation-mode*
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Fabian Affolter 2011-06-03 09:50:06 UTC
At the moment there is no license information available from upstream.

https://github.com/RaphaelKimmig/Gnome-Presentation-Mode/issues/5

Comment 3 Clint Savage 2011-06-04 13:20:09 UTC
License seems to be the only hold-up.

$ rpmlint /tmp/gnome-shell-extension-presentation-mode-0-0.1.git89577dc.fc15.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

src.rpm is clean

$ rpmlint /var/lib/mock/fedora-15-x86_64/result/gnome-shell-extension-presentation-mode-0-0.1.git89577dc.fc15.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

binary rpm is clean

$ rpmlint ~/rpmbuild/SPECS/gnome-shell-extension-presentation-mode.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.

spec is clean

All MUSTS are met except the licensing. When you have the licensing sorted out, please update and I will finish the review.

Cheers,

Clint

Comment 4 Fabian Affolter 2011-06-05 10:27:52 UTC
Thank you, Clint.

(In reply to comment #3)
> License seems to be the only hold-up.
> All MUSTS are met except the licensing. When you have the licensing sorted out,
> please update and I will finish the review.

done

* Sun Jun 05 2011 Fabian Affolter <fabian> - 0-0.2.gitc3ce6b2
- License is GPLv2+
- COPYING file added

Here are the updated files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gnome-shell-extension-presentation-mode.spec
SRPM URL:http://fab.fedorapeople.org/packages/SRPMS/gnome-shell-extension-presentation-mode-0-0.2.gitc3ce6b2.fc15.src.rpm

Comment 5 Clint Savage 2011-06-05 15:52:20 UTC
$ rpmlint /tmp/gnome-shell-extension-presentation-mode-0-0.2.gitc3ce6b2.fc15.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint ~/rpmbuild/SPECS/gnome-shell-extension-presentation-mode.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint /var/lib/mock/fedora-15-x86_64/result/gnome-shell-extension-presentation-mode-0-0.2.gitc3ce6b2.fc15.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Documentation and license appear to be in order. 

Package approved!

Comment 6 Fabian Affolter 2011-06-05 16:05:55 UTC
New Package VCS Request
=======================
Package Name: gnome-shell-extension-presentation-mode
Short Description: A gnome-shell extension to control the screensaver
Owners: fab
Branches: F15
InitialCC:

Comment 7 Gwyn Ciesla 2011-06-05 22:34:51 UTC
New Package RCS Request
=======================
Package Name: gnome-shell-extension-presentation-mode
Short Description: A gnome-shell extension to control the screensaver
Owners: fab
Branches: f15
InitialCC:

Comment 8 Gwyn Ciesla 2011-06-05 22:35:24 UTC
New Package SCM Request
=======================
Package Name: gnome-shell-extension-presentation-mode
Short Description: A gnome-shell extension to control the screensaver
Owners: fab
Branches: f15
InitialCC:

Comment 9 Gwyn Ciesla 2011-06-05 22:35:55 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2011-06-06 18:08:24 UTC
gnome-shell-extension-presentation-mode-0-0.2.gitc3ce6b2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/gnome-shell-extension-presentation-mode-0-0.2.gitc3ce6b2.fc15

Comment 11 Fedora Update System 2011-06-07 04:41:48 UTC
gnome-shell-extension-presentation-mode-0-0.2.gitc3ce6b2.fc15 has been pushed to the Fedora 15 testing repository.

Comment 12 Fedora Update System 2011-06-15 18:30:02 UTC
gnome-shell-extension-presentation-mode-0-0.2.gitc3ce6b2.fc15 has been pushed to the Fedora 15 stable repository.


Note You need to log in before you can comment on or make changes to this bug.