Bug 710475 - Review Request: gnome-shell-extension-iconplacesbookmarks - A gnome-shell extension to add a Places and Bookmarks menu
Summary: Review Request: gnome-shell-extension-iconplacesbookmarks - A gnome-shell ext...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mario Blättermann
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-03 13:53 UTC by Fabian Affolter
Modified: 2011-12-23 13:10 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-23 13:10:23 UTC
Type: ---
mario.blaettermann: fedora-review?


Attachments (Terms of Use)

Description Fabian Affolter 2011-06-03 13:53:59 UTC
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gnome-shell-extension-iconplacesbookmarks.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gnome-shell-extension-iconplacesbookmarks-1.0-1.fc15.src.rpm

Project URL: http://www.fpmurphy.com/gnome-shell-extensions/

Description:
This Gnome Shell extension adds a Places and Bookmarks menu to panel.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3108210

rpmlint output:
[fab@laptop021 SRPMS]$ rpmlint gnome-shell-extension-iconplacesbookmarks*
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[fab@laptop021 noarch]$ rpmlint gnome-shell-extension-iconplacesbookmarks*
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Rahul Sundaram 2011-06-04 14:38:44 UTC
This duplicates an existing extension already in the repo

Comment 2 Tim Lauridsen 2011-06-05 08:32:51 UTC
(In reply to comment #1)
> This duplicates an existing extension already in the repo

The functionality is equal but the look is different and it don't conflict with 
 places-menu extension, so I think it go into Fedora, the the user can choose.

Comment 3 Mario Blättermann 2011-08-30 18:37:19 UTC
The source package 1.0 is no longer available, please update to 1.1.

Comment 5 Mario Blättermann 2011-10-02 14:16:21 UTC
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3397099

$ rpmlint -i -v *
gnome-shell-extension-iconplacesbookmarks.src: I: checking
gnome-shell-extension-iconplacesbookmarks.src: I: checking-url http://www.fpmurphy.com/gnome-shell-extensions/ (timeout 10 seconds)
gnome-shell-extension-iconplacesbookmarks.src: I: checking-url http://www.fpmurphy.com/gnome-shell-extensions/iconplacesbookmarks-1.1.tar.gz (timeout 10 seconds)
gnome-shell-extension-iconplacesbookmarks.noarch: I: checking
gnome-shell-extension-iconplacesbookmarks.noarch: W: incoherent-version-in-changelog 1.0-1 ['1.1-1.fc17', '1.1-1']
The latest entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

gnome-shell-extension-iconplacesbookmarks.noarch: I: checking-url http://www.fpmurphy.com/gnome-shell-extensions/ (timeout 10 seconds)
gnome-shell-extension-iconplacesbookmarks.spec: I: checking-url http://www.fpmurphy.com/gnome-shell-extensions/iconplacesbookmarks-1.1.tar.gz (timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 1 warnings.


The version number in the changelog is still incorrect for the last entry.

Comment 6 Mario Blättermann 2011-10-30 11:33:36 UTC
Link to the tarball has been changed:
http://www.fpmurphy.com/gnome-shell-extensions/3.0/iconplacesbookmarks-1.1.tar.gz

The spec file has to be changed to match the new location.

Comment 7 Fabian Affolter 2011-12-23 13:10:23 UTC
A lot of Shell Extensions are available at [1]. I think that it doesn't make sense to go on with this review.

[1] https://extensions.gnome.org/


Note You need to log in before you can comment on or make changes to this bug.