Bug 710554 - [cli] Spacewalk shell picks up '--help' anywhere in command input
Summary: [cli] Spacewalk shell picks up '--help' anywhere in command input
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Spacewalk
Classification: Community
Component: API
Version: 1.5
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: ---
Assignee: Jan Pazdziora (Red Hat)
QA Contact: Red Hat Satellite QA List
URL:
Whiteboard:
Depends On: 707936
Blocks: space15
TreeView+ depends on / blocked
 
Reported: 2011-06-03 16:57 UTC by Adam Price
Modified: 2011-07-21 14:43 UTC (History)
3 users (show)

Fixed In Version: spacecmd-1.5.2-1
Clone Of: 707936
Environment:
Last Closed: 2011-07-21 14:43:42 UTC
Embargoed:


Attachments (Terms of Use)

Description Adam Price 2011-06-03 16:57:25 UTC
+++ This bug was initially created as a clone of Bug #707936 +++

Description of problem:
Spacewalk shell displays help message if it finds '--help' anywhere in input.

Version-Release number of selected component (if applicable):
latest spacewalk from the git master.

How reproducible:
always: other calls are affected as well - the same behavior

Steps to Reproduce:
1. invoke Spacewalk calls using "--help" in the arguments
2.
3.
  
Actual results:
Help is displaying instead of processing the command

Expected results:
the command should get properly processed.

Additional info:

--- Additional comment from lzap on 2011-06-02 10:25:17 EDT ---

Pulp is probably affected too (pulp-admin).

--- Additional comment from lzap on 2011-06-02 10:31:49 EDT ---

Sorry the code is from the Spacewalk project:

spacecmd/src/lib/shell.py:        if re.search('--help', line):

I guess it has the same issue then ;-)

--- Additional comment from adprice on 2011-06-03 10:56:07 EDT ---

the command is now properly processed in the shell.

Comment 1 Jan Pazdziora (Red Hat) 2011-06-06 07:30:06 UTC
Making the bugzilla public.

Reverting state to NEW as I don't believe we have a correct patch:

   http://www.redhat.com/archives/spacewalk-devel/2011-June/msg00011.html

Comment 2 Jan Pazdziora (Red Hat) 2011-06-08 12:34:23 UTC
Aron fixed the parameter handling in spacecmd-1.5.2-1.

Comment 3 Jan Pazdziora (Red Hat) 2011-07-19 19:36:49 UTC
This bugzilla is currently MODIFIED, so we believe the fix is in the Spacewalk nightly yum repository at http://spacewalk.redhat.com/yum/nightly/

Therefore, moving ON_QA.

Comment 4 Jan Pazdziora (Red Hat) 2011-07-21 14:43:42 UTC
Spacewalk 1.5 was released.


Note You need to log in before you can comment on or make changes to this bug.