Bug 710648 - Review Request: clusterPy - Custom analytical geographic regionalization
Summary: Review Request: clusterPy - Custom analytical geographic regionalization
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ken Dreyer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-03 22:01 UTC by Volker Fröhlich
Modified: 2011-10-16 00:58 UTC (History)
5 users (show)

Fixed In Version: clusterPy-0.9.9-3.fc16
Clone Of:
Environment:
Last Closed: 2011-10-13 23:55:20 UTC
Type: ---
Embargoed:
ktdreyer: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Volker Fröhlich 2011-06-03 22:01:22 UTC
Spec URL: http://www.geofrogger.net/review/clusterPy.spec
SRPM URL: http://www.geofrogger.net/review/clusterPy-0.9.9-1.fc14.src.rpm
Description:
Analytical regionalization (also known as spatially constrained clustering) is a
scientific way to decide how to group a large number of geographic areas or
points into a smaller number of regions based on similarities in one or more
variables (i.e., income, ethnicity, environmental condition, etc.) that the
researcher believes are important for the topic at hand.

Conventional conceptions of how areas should be grouped into regions may either
not be relevant to the information one is trying to illustrate (i.e., using
political regions to map air pollution) or may actually be designed in ways to
bias aggregated results. 

ClusterPy offers the following algorithms: Arisel, AZP, AZP-Simulated Annealing,
AZP-Tabu, AZP-R-Tabu, Max-p-regions (Tabu), AMOEBA, SOM and geoSOM.

I contacted upstream for their thoughts on summary and description. Thus that may change.

I only plan to maintain this package in Fedora.

Comment 1 Volker Fröhlich 2011-06-03 22:02:20 UTC
Argh, messy!

Comment 2 Volker Fröhlich 2011-06-03 22:32:29 UTC
Updated description and summary:

Spec URL: http://www.geofrogger.net/review/clusterPy.spec
SRPM URL: http://www.geofrogger.net/review/clusterPy-0.9.9-2.fc14.src.rpm

Description:

Analytical regionalization is a scientific way to decide how to group or
cluster a large number of geographic areas or points into a smaller number
of regions based on their similarities. ClusterPy offers the following
clustering algorithms: Arisel, AZP, AZP-Simulated Annealing, AZP-Tabu,
AZP-R-Tabu, Max-p-regions (Tabu), AMOEBA, SOM and geoSOM.

Summary: Analytical regionalization and spatial clustering of geographic areas

Comment 3 Ken Dreyer 2011-10-05 00:23:49 UTC
OK - MUST: rpmlint must be run on source and binaries

$ rpmlint /var/lib/mock/fedora-16-i386/result/clusterPy-0.9.9-2.fc16.noarch.rpm 
clusterPy.noarch: W: spelling-error Summary(en_US) Analytical -> Analytically, Analytic, Catalytic
clusterPy.noarch: W: spelling-error Summary(en_US) regionalization -> rationalization, marginalization, denationalization
clusterPy.noarch: W: spelling-error %description -l en_US Analytical -> Analytically, Analytic, Catalytic
clusterPy.noarch: W: spelling-error %description -l en_US regionalization -> rationalization, marginalization, denationalization
clusterPy.noarch: W: spelling-error %description -l en_US Arisel -> Ariel, Arise, Arises
clusterPy.noarch: W: spelling-error %description -l en_US geoSOM -> geom
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

$ rpmlint /var/lib/mock/fedora-16-i386/result/clusterPy-0.9.9-2.fc16.src.rpm 
clusterPy.src: W: spelling-error Summary(en_US) Analytical -> Analytically, Analytic, Catalytic
clusterPy.src: W: spelling-error Summary(en_US) regionalization -> rationalization, marginalization, denationalization
clusterPy.src: W: spelling-error %description -l en_US Analytical -> Analytically, Analytic, Catalytic
clusterPy.src: W: spelling-error %description -l en_US regionalization -> rationalization, marginalization, denationalization
clusterPy.src: W: spelling-error %description -l en_US Arisel -> Ariel, Arise, Arises
clusterPy.src: W: spelling-error %description -l en_US geoSOM -> geom
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

$ rpmlint clusterPy.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

False positives on spelling.  No problems here.

OK - MUST: named according to the Package Naming Guidelines
OK - MUST: spec file name matches the base package %{name}
OK - MUST: package meets the Packaging Guidelines
OK - MUST: license file included in %doc
OK - MUST: spec is in American English
OK - MUST: spec is legible
OK - MUST: sources match the upstream source by MD5
392beb2c03b14f710055c33547ec7ced
OK - MUST: successfully compiles and builds into binary rpms on F15/16.
N/A - MUST: no ExcludeArch.
OK - MUST: all build dependencies are listed in BuildRequires.
N/A - MUST: handles locales properly with %find_lang
N/A - MUST: calls ldconfig in %post and %postun
OK - MUST: does not bundle copies of system libraries.
N/A - MUST: not designed to be relocatable
OK - MUST: owns all directories that it creates
OK - MUST: no duplicate files in the %files listing
OK - MUST: permissions on files are set properly
OK - MUST: consistently uses macros
OK - MUST: package contains code, or permissable content
N/A - MUST: Large documentation files should go in a -doc subpackage
OK - MUST: Files included as %doc do not affect the runtime of the application
N/A - MUST: Header files must be in a -devel package
N/A - MUST: Static libraries must be in a -static package
N/A - MUST: If a package contains library files with a suffix, then library
files that end in .so must go in a -devel package.
N/A - MUST: devel packages must require the base package using a fully versioned
dependency
OK - MUST: The package does not contain any .la libtool archives.
N/A - MUST: Packages containing GUI applications must include a %{name}.desktop
file
OK - MUST: package does not own files or directories already owned by other
packages.
OK - MUST: all filenames valid UTF-8


SHOULD Items:
OK - SHOULD: Source package includes license text(s) as a separate file.
N/A - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
OK - SHOULD: builds in mock.
OK - SHOULD: compiles and builds into binary rpms on all supported
architectures.
OK - SHOULD: functions as described.
OK - SHOULD: Scriptlets are sane.
N/A - SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg
OK - SHOULD: no file dependencies outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin


Other items:
OK - latest stable version
OK - SourceURL valid


Issues:

Personal nit: no need for "index.html" in the URL. It's sort of like extraneous uses of "cat" in shell scripts :)

APPROVED

Comment 4 Volker Fröhlich 2011-10-05 06:43:05 UTC
Thank you for reviewing, Ken! I'll change the URL for the actual build.

Comment 5 Gwyn Ciesla 2011-10-05 12:02:22 UTC
Please include an SCM request when setting the fedora-cvs flag, thanks!

https://fedoraproject.org/wiki/Package_SCM_admin_requests

Comment 6 Volker Fröhlich 2011-10-05 12:21:40 UTC
Sorry, out of my mind!

Comment 7 Volker Fröhlich 2011-10-05 12:25:23 UTC
New Package SCM Request
=======================
Package Name: clusterPy
Short Description: Library of spatially constrained clustering algorithms
Owners: volter
Branches: f15 f16

Comment 8 Gwyn Ciesla 2011-10-05 13:12:34 UTC
And the BZ isn't assigned to the reviewer, and the review flag isn't set to
+. :)

Comment 9 Ken Dreyer 2011-10-05 13:16:37 UTC
Sorry Jon, thanks :)

Comment 10 Volker Fröhlich 2011-10-05 14:13:09 UTC
New Package SCM Request
=======================
Package Name: clusterPy
Short Description: Library of spatially constrained clustering algorithms
Owners: volter
Branches: f15 f16

Comment 11 Gwyn Ciesla 2011-10-05 14:15:27 UTC
Git done (by process-git-requests).

Comment 12 Gwyn Ciesla 2011-10-05 14:16:00 UTC
No worries, thanks!

Comment 13 Fedora Update System 2011-10-05 15:52:06 UTC
clusterPy-0.9.9-3.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/clusterPy-0.9.9-3.fc16

Comment 14 Fedora Update System 2011-10-05 15:52:15 UTC
clusterPy-0.9.9-3.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/clusterPy-0.9.9-3.fc15

Comment 15 Fedora Update System 2011-10-05 17:16:59 UTC
clusterPy-0.9.9-3.fc16 has been pushed to the Fedora 16 testing repository.

Comment 16 Fedora Update System 2011-10-13 23:55:20 UTC
clusterPy-0.9.9-3.fc15 has been pushed to the Fedora 15 stable repository.

Comment 17 Fedora Update System 2011-10-16 00:58:53 UTC
clusterPy-0.9.9-3.fc16 has been pushed to the Fedora 16 stable repository.


Note You need to log in before you can comment on or make changes to this bug.