Spec URL: http://packages.getwallaby.com/ruby-spqr.spec
SRPM URL: http://packages.getwallaby.com/ruby-spqr-0.3.3-2.fc14.src.rpm
Description: SPQR makes it very simple to expose methods on Ruby objects over the Qpid Management Framework.
A new SRPM is available at http://packages.getwallaby.com/ruby-spqr-0.3.3-4.fc14.src.rpm
The most recent SRPM is available from packages.getwallaby.com.
== Review ==
- rpmlint checks return:
ruby-spqr.noarch: W: spurious-executable-perm /usr/share/doc/ruby-spqr-0.3.4/examples/hello.rb
ruby-spqr.noarch: W: doc-file-dependency /usr/share/doc/ruby-spqr-0.3.4/examples/logservice.rb /usr/bin/env
spqr-gen.noarch: W: spelling-error Summary(en_US) xml -> XML, ml, x ml
spqr-gen.noarch: W: no-manual-page-for-binary spqr-gen.rb
All safe to ignore.
- package meets naming guidelines
- package meets packaging guidelines
- license (ASL 2.0) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (d3ef30d1000f1f00187cc1a6d59d8713e37701b21d4ff4c90368f55a33ad6e5a)
- package compiles on f16 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
It all looks good, so I'm marking this as APPROVED.
One minor item: I don't think there is a need for Requires: ruby, since you have Requires: ruby(abi) = 1.8, but this should be safe to remove before committing to Fedora git.
Hi, could you please enlighten me why did you packaged the library as Ruby library instead of RubyGem?
New Package SCM Request
Package Name: ruby-spqr
Short Description: easy QMF agent framework for Ruby
Branches: f15 f16
Git done (by process-git-requests).
ruby-spqr-0.3.5-1.fc16 has been submitted as an update for Fedora 16.
ruby-spqr-0.3.5-1.fc15 has been submitted as an update for Fedora 15.
ruby-spqr-0.3.5-1.fc15 has been pushed to the Fedora 15 testing repository.
ruby-spqr-0.3.5-1.fc15 has been pushed to the Fedora 15 stable repository.
ruby-spqr-0.3.5-1.fc16 has been pushed to the Fedora 16 stable repository.