RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 712115 - corosync confdb connection can cause segfault
Summary: corosync confdb connection can cause segfault
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: corosync
Version: 6.1
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: rc
: 6.2
Assignee: Jan Friesse
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-09 14:32 UTC by Jan Friesse
Modified: 2011-12-06 11:51 UTC (History)
4 users (show)

Fixed In Version: corosync-1.4.0-1.el6
Doc Type: Bug Fix
Doc Text:
Cause: A race condition in the internal confdb data storage system would had incorrect mutual exclusion. Consequence: Corosync would segfault under rare and contrived circumstances. Fix: The race condition was fixed. Result: Corosync no longer segfaults.
Clone Of:
Environment:
Last Closed: 2011-12-06 11:51:01 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Patch for first problem (3.21 KB, patch)
2011-06-09 14:32 UTC, Jan Friesse
no flags Details | Diff
Patch for second problem (5.30 KB, patch)
2011-06-09 14:33 UTC, Jan Friesse
no flags Details | Diff
test-confdb patch which checks first problem in valgrind (2.16 KB, patch)
2011-06-09 14:35 UTC, Jan Friesse
no flags Details | Diff
First patch backprted to current RHEL 6 package (5.32 KB, patch)
2011-06-10 12:15 UTC, Jan Friesse
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:1515 0 normal SHIPPED_LIVE corosync bug fix and enhancement update 2011-12-06 00:38:47 UTC

Description Jan Friesse 2011-06-09 14:32:59 UTC
Created attachment 503906 [details]
Patch for first problem

Description of problem:
Problem 1:
in confdb_object_iter result of object_find_create is now properly
checked. object_find_create can return -1 if object doesn't exists.
Without this check, incorrect handle (memory garbage) was directly
passed to object_find_next.

Problem 2:
Following situation could happen:
- process 1 thru confdb creates find handle
- calls find iteration once
- different process 2 deletes object pointed by process 1 iterator
- process 1 calls iteration again ->
  object_find_instance->find_child_list is invalid pointer

-> segfault

Now object_find_create creates array of matching object handlers and
object_find_next uses that array together with check for name. This
prevents situation where between steps 2 and 3 new object is created
with different name but sadly with same handler.

Version-Release number of selected component (if applicable):
Corosync master

How reproducible:
Often but it's race so depends on HW, ... Problem 1 is visible in valgrind.

Steps to Reproduce:
One node.
# for i in `seq 1 5`;do (while true;do corosync-objctl -a | grep closed;done)& done 
# corosync -f
  
Actual results:
segfault

Expected results:
no segfault

Additional info:

Comment 1 Jan Friesse 2011-06-09 14:33:43 UTC
Created attachment 503907 [details]
Patch for second problem

Comment 2 Jan Friesse 2011-06-09 14:35:39 UTC
Created attachment 503909 [details]
test-confdb patch which checks first problem in valgrind

Corosync must be running thru valgrind

Comment 3 Jan Friesse 2011-06-09 14:36:01 UTC
Patches posted to ML

Comment 5 Jan Friesse 2011-06-10 12:15:28 UTC
Created attachment 504088 [details]
First patch backprted to current RHEL 6 package

Comment 10 Steven Dake 2011-10-27 18:47:37 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause: A race condition in the internal confdb data storage system would had incorrect mutual exclusion.
  Consequence: Corosync would segfault under rare and contrived circumstances.
  Fix: The race condition was fixed.
  Result: Corosync no longer segfaults.

Comment 11 errata-xmlrpc 2011-12-06 11:51:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1515.html


Note You need to log in before you can comment on or make changes to this bug.