Spec URL: http://timlau.fedorapeople.org/files/packages/theme-selector/SPECS/gnome-shell-theme-ubuntu-ambiance.spec SRPM URL: http://timlau.fedorapeople.org/files/packages/theme-selector/SRPMS/gnome-shell-theme-ubuntu-ambiance-1.0-1.fc15.src.rpm Description: The ubuntu-ambiance gnome-shell theme
Even though Ubuntu has trademark guidelines (which are painfully vague about 3rd party content like theming), I feel that the potential for confusion is sufficient to block this on FE-Legal. In a quick look at the theme, it may be using the Ubuntu background art (I haven't looked at the "Narwhal" background, so it is possible that I'm mistaken here), which is possibly under its own set of license terms. Assuming that the art is freely distributable, all that would need to happen here is to rename this package to resolve the trademark concern.
Created attachment 505103 [details] theme artwork No logo here, so it should be ok ?
Created attachment 505105 [details] theme preview The theme preview contains big whales, but it don't look like something trademarked. But they can be replace with screendump done on a fedora F15 default wallpaper if needed
I will rename it from *-ubuntu-ambiance to *-ambiance, it should solve the potential "Ubuntu" trademark thing.
Rename it and redo the preview, and we should be fine. I was going to suggest "purple-people-eater", but "ambience" is also acceptable. :)
Ok, now I have renamed the package to *-ambiance The 3 include theme variant is now named Ambiance-light etc. Review images are replaced, with screen shots under fedora. SPEC: http://timlau.fedorapeople.org/files/packages/theme-selector/SPECS/gnome-shell-theme-ambiance.spec SRPM: http://timlau.fedorapeople.org/files/packages/theme-selector/SRPMS/gnome-shell-theme-ambiance-1.0-1.fc15.src.rpm
Lifting FE-Legal, thanks for your effort Tim.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3397410 $ rpmlint -i -v *gnome-shell-theme-ambiance.src: I: checking gnome-shell-theme-ambiance.src: I: checking-url http://half-left.deviantart.com/art/GNOME-Shell-Ubuntu-Ambience-210264151 (timeout 10 seconds) gnome-shell-theme-ambiance.src: I: checking-url http://www.deviantart.com/download/210264151/gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip (timeout 10 seconds) gnome-shell-theme-ambiance.src: W: uncompressed-zip gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip The zip file is not compressed. gnome-shell-theme-ambiance.noarch: I: checking gnome-shell-theme-ambiance.noarch: W: incoherent-version-in-changelog 1.0 ['1.0-1.fc17', '1.0-1'] The latest entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. gnome-shell-theme-ambiance.noarch: I: checking-url http://half-left.deviantart.com/art/GNOME-Shell-Ubuntu-Ambience-210264151 (timeout 10 seconds) gnome-shell-theme-ambiance.spec: I: checking-url http://www.deviantart.com/download/210264151/gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Some issues: The changelog entry needs to be tagged with the current version number, "1.0-1" instead of "1.0". In general, you have to screw up the version number in your spec after any change you made. Currently, we are actually at version 1.0-2. The Zip file which contains the primary source is unzipped. Well, this is handled correctly during the build process. As far as I can see, there's no other source package available. Could be ignored. There's a typo in a comment line in your spec, "tradmark" instead of "trademark". You should add the -p switch to the copy command to keep time stamps.
Thanks for reviewing: New spec & srpms with the following changes: Add -p to cp commands. fixed changelog versioning fixed typo http://timlau.fedorapeople.org/files/packages/theme-selector/SRPMS/gnome-shell-theme-ambiance-1.0-2.fc16.src.rpm http://timlau.fedorapeople.org/files/packages/theme-selector/SPECS/gnome-shell-theme-ambiance.spec Can't do much about the .zip is not compressed, but it not a big problem :)
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3437570 $ rpmlint -i -v * gnome-shell-theme-ambiance.noarch: I: checking gnome-shell-theme-ambiance.noarch: I: checking-url http://half-left.deviantart.com/art/GNOME-Shell-Ubuntu-Ambience-210264151 (timeout 10 seconds) gnome-shell-theme-ambiance.src: I: checking gnome-shell-theme-ambiance.src: I: checking-url http://half-left.deviantart.com/art/GNOME-Shell-Ubuntu-Ambience-210264151 (timeout 10 seconds) gnome-shell-theme-ambiance.src: I: checking-url http://www.deviantart.com/download/210264151/gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip (timeout 10 seconds) gnome-shell-theme-ambiance.src: W: uncompressed-zip gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip The zip file is not compressed. gnome-shell-theme-ambiance.spec: I: checking-url http://www.deviantart.com/download/210264151/gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 1 warnings. Looks fine so far. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPLv3 [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * 69de62f03b7c5f19f76eac81975c5d43 gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip 69de62f03b7c5f19f76eac81975c5d43 gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip.packaged [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [.] MUST: All build dependencies must be listed in BuildRequires. Nothing to build at all. [.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. I assume the packager has tested it. Don't know how to test it on my system, due to hardware incompatibility. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [.] SHOULD: Your package should contain man pages for binaries/scripts. ---------------- PACKAGE APPROVED ----------------
Thanks for reviewing :)
New Package SCM Request ======================= Package Name: gnome-shell-theme-ambiance Short Description: ambiance theme for gnome-shell Owners: timlau Branches: f15 f16 InitialCC:
Git done (by process-git-requests).
Wouldn't it be time to feed the Git now...?
(In reply to comment #14) > Wouldn't it be time to feed the Git now...? Git is feeded, but it look like i never pushed it for F16 https://admin.fedoraproject.org/updates/gnome-shell-theme-ambiance