Bug 712705 - Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Summary: Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 15
Hardware: noarch
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Mohamed El Morabity
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-12 15:27 UTC by Guillaume Kulakowski
Modified: 2011-07-04 18:54 UTC (History)
4 users (show)

Fixed In Version: gnome-shell-extension-icon-manager-0-0.2.gite9deb2b.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-07-04 18:54:57 UTC
Type: ---
Embargoed:
pikachu.2014: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Guillaume Kulakowski 2011-06-12 15:27:05 UTC
Spec URL:
http://llaumgui.fedorapeople.org/review/gnome-shell-extension-icon-manager/gnome-shell-extension-icon-manager.spec
SRPM URL:
http://llaumgui.fedorapeople.org/review/gnome-shell-extension-icon-manager/gnome-shell-extension-icon-manager-0-0.1.gited463a5.fc15.src.rpm
RPM URL:
http://llaumgui.fedorapeople.org/review/gnome-shell-extension-icon-manager/gnome-shell-extension-icon-manager-0-0.1.gited463a5.fc15.noarch.rpm

Project URL: https://github.com/MrTheodor/gnome-shell-ext-icon-manager

Description:
Add/remove icons from top bar panel by simple editing gconf settings.

rpmlint output:
builder@enterprise ~> rpmlint rpmbuild/*/*.rpm
gnome-shell-extension-icon-manager.noarch: W: spelling-error %description -l en_US gconf -> confab
gnome-shell-extension-icon-manager.src: W: spelling-error %description -l en_US gconf -> confab
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Comment 1 Mohamed El Morabity 2011-06-12 15:46:30 UTC
* Useless Requires condition on gnome-shell (Fedora 15 provides GS 3.0.2).
* Don't use %{__foo} macros: they make the .spec file harder to read. Using them is discouraged by the Project:
   https://bugzilla.redhat.com/show_bug.cgi?id=669311#c9

Comment 2 Mohamed El Morabity 2011-06-12 17:01:38 UTC
Remove also the INSTALL file in %doc. Users don't care about manual installation.

Comment 4 Kevin Verma 2011-06-17 11:07:22 UTC
(In reply to comment #3)
> Updated :
> 
> Spec URL:
> http://llaumgui.fedorapeople.org/review/gnome-shell-extension-icon-manager/gnome-shell-extension-icon-manager.spec
> SRPM URL:
> http://llaumgui.fedorapeople.org/review/gnome-shell-extension-icon-manager/gnome-shell-extension-icon-manager-0-0.1.gited463a5.fc15.src.rpm
> RPM URL:
> http://llaumgui.fedorapeople.org/review/gnome-shell-extension-icon-manager/gnome-shell-extension-icon-manager-0-0.1.gited463a5.fc15.noarch.rpm

I tested the updated RPM and found that this extension does move task tray items out of messageTray into the top-pannel. 

Following the text of my configuration for org.gnome.shell.extentsions.icon-manager using dconf-editor:
--snip--
['a11y', 'gnote', 'parcellite', 'empathy', 'pidgin', 'workrave']
--snip--

I have only used this rpm to see if this extension works for given purpose, but I have not reviewed the RPM in particular.

Comment 5 Mohamed El Morabity 2011-06-17 12:41:46 UTC
The description is not true: the extension is configured through gsettings, not gconf. Plese fix it... And report the issue upstream.

Comment 6 Guillaume Kulakowski 2011-06-21 17:49:51 UTC
Error reporting : https://github.com/MrTheodor/gnome-shell-ext-icon-manager/issues/1

Comment 8 Mohamed El Morabity 2011-06-25 10:04:45 UTC
Here is the review.

MUST: rpmlint must be run on every package.
->OK, only false-positive spelling issues

MUST: The package must be named according to the Package Naming Guidelines.
->OK

MUST: The spec file name must match the base package %{name}, in the format
      %{name}.spec unless your package has an exemption.
->OK

MUST: The package must meet the Packaging Guidelines.
->OK

MUST: The package must be licensed with a Fedora approved license and meet the
      Licensing Guidelines.
->OK

MUST: The License field in the package spec file must match the actual license.
->OK, all files under GPL v3 or more

MUST: If (and only if) the source package includes the text of the license(s) in
      its own file, then that file, containing the text of the license(s) for
      the package must be included in %doc.
      ->N/A

MUST: The spec file must be written in American English.
->OK

MUST: The spec file for the package MUST be legible.
->OK

MUST: The sources used to build the package must match the upstream source, as
      provided in the spec URL.
->OK, md5sum = 21c385a7c6ae635b27e7b6fdb9c41f0c

MUST: The package MUST successfully compile and build into binary rpms on at
      least one primary architecture.
->OK

MUST: If the package does not successfully compile, build or work on an
      architecture, then those architectures should be listed in the spec in
      ExcludeArch.
->N/A

MUST: All build dependencies must be listed in BuildRequires, except for any
      that are listed in the exceptions section of the Packaging Guidelines ;
      inclusion of those as BuildRequires is optional.
->OK

MUST: The spec file MUST handle locales properly. This is done by using the
      %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
->N/A

MUST: Every binary RPM package (or subpackage) which stores shared library files
      (not just symlinks) in any of the dynamic linker's default paths, must
      call ldconfig in %post and %postun.
->N/A

MUST: Packages must NOT bundle copies of system libraries.
->OK

MUST: If the package is designed to be relocatable, the packager must state this
      fact in the request for review, along with the rationalization for
      relocation of that specific package. Without this, use of Prefix: /usr is
      considered a blocker.
->N/A

MUST: A package must own all directories that it creates. If it does not create
      a directory that it uses, then it should require a package which does
      create that directory.
>OK

MUST: A Fedora package must not list a file more than once in the spec file's
      %files listings. 
->OK

MUST: Permissions on files must be set properly. Executables should be set with
      executable permissions, for example. Every %files section must include a
      %defattr(...) line.
->OK

MUST: Each package must consistently use macros.
->OK

MUST: The package must contain code, or permissable content.
->OK

MUST: Large documentation files must go in a -doc subpackage.
->N/A

MUST: If a package includes something as %doc, it must not affect the runtime of
      the application. To summarize: If it is in %doc, the program must run
      properly if it is not present.
->OK

MUST: Header files must be in a -devel package.
->N/A

MUST: Static libraries must be in a -static package.
->N/A

MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
      then library files that end in .so (without suffix) must go in a -devel
      package.
->N/A

MUST: In the vast majority of cases, devel packages must require the base
      package using a fully versioned dependency: Requires: %{name} =
      %{version}-%{release}.
->N/A

MUST: Packages must NOT contain any .la libtool archives, these must be removed
      in the spec if they are built.
->N/A

MUST: Packages containing GUI applications must include a %{name}.desktop file,
      and that file must be properly installed with desktop-file-install in the
      %install section.
->N/A

MUST: Packages must not own files or directories already owned by other
      packages.
->OK

MUST: All filenames in rpm packages must be valid UTF-8.
->OK

Approved.

Comment 9 Guillaume Kulakowski 2011-06-25 12:34:52 UTC
New Package SCM Request
=======================
Package Name: gnome-shell-extension-icon-manager
Short Description: A gnome-shell extension to manage icons in top bar
Owners: llaumgui
Branches: f15
InitialCC:

Comment 10 Gwyn Ciesla 2011-06-25 13:24:03 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2011-06-25 13:56:12 UTC
gnome-shell-extension-icon-manager-0-0.2.gite9deb2b.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/gnome-shell-extension-icon-manager-0-0.2.gite9deb2b.fc15

Comment 12 Fedora Update System 2011-06-25 20:02:04 UTC
gnome-shell-extension-icon-manager-0-0.2.gite9deb2b.fc15 has been pushed to the Fedora 15 testing repository.

Comment 13 Fedora Update System 2011-07-04 18:54:52 UTC
gnome-shell-extension-icon-manager-0-0.2.gite9deb2b.fc15 has been pushed to the Fedora 15 stable repository.


Note You need to log in before you can comment on or make changes to this bug.