RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 713474 - spice server crash on ring_remove ASSERT(item->next != NULL && item->prev != NULL)
Summary: spice server crash on ring_remove ASSERT(item->next != NULL && item->prev != ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: spice-server
Version: 6.1
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: rc
: ---
Assignee: Yonit Halperin
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks: 723676
TreeView+ depends on / blocked
 
Reported: 2011-06-15 14:04 UTC by Yonit Halperin
Modified: 2012-03-06 10:22 UTC (History)
6 users (show)

Fixed In Version: spice-server-0.8.2-1.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-06 15:21:23 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
proposed solution (2.16 KB, patch)
2011-06-15 14:14 UTC, Yonit Halperin 		no flags Details | Diff
solution v2 (2.23 KB, patch)
2011-07-12 12:28 UTC, Yonit Halperin 		no flags Details | Diff
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:1634 0 normal SHIPPED_LIVE spice-server bug fix and enhancement update 2011-12-06 00:50:43 UTC

Description Yonit Halperin 2011-06-15 14:04:40 UTC 
Description of problem:
When spice client connects/reconnects to the server, the red_worker might reach a scenario where it tries to remove from the "current tree" an item that has already been removed and released. Specifically:

1. client is not connected
2. surface's x current tree contains drawable d1
3. client gets connected
4. drawable d2 is being processed. It has the same surface and region as d1.
5. red_current_add_equal is called
   (i) red_pipe_add_drawable(d2) is called ==> since the client wasn’t connected before, red_handle_drawable_surfaces_client_synced performs red_current_flush on surface x.
   (ii) remove_drawable(d2) is called while d2 is no longer in "current" and has already been released.
   (iii) ASSERT(item->next != NULL && item->prev != NULL) occurs in the call
         to ring_remove in current_remove_drawable

How reproducible:
I encountered the crash while preforming tests on S3/4 support (the patches are not yet committed). The guest was Windows xp. 
1) I logged in 
2) I started playing a movie with VLC, and then I performed standby. 
3) While returning from stand by, I disconnected the client and reconnected it. Then the crash occurred. 
However, this bug is not related to S3 and exists since offscreen surfaces were introduced (RHEL 6.1)
Comment 2 Yonit Halperin 2011-06-15 14:14:46 UTC 
Created attachment 504884 [details]
proposed solution
Comment 5 Yonit Halperin 2011-07-12 12:28:20 UTC 
Created attachment 512413 [details]
solution v2

This version is more efficient since it removes the other_drawable
from the tree before red_handle_drawable_surfaces_client_synced is called.
In this manner, other_drawable won't be unnecessarily rendered if
update_area is called.
Comment 8 errata-xmlrpc 2011-12-06 15:21:23 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1634.html
Note You need to log in before you can comment on or make changes to this bug.