Created attachment 504934 [details] Patch Description of problem: When syncing a repo with a blacklist filter, "pulp-admin repo status" says: Last Error: 2011-06-15 14:32:59-04:00 ValueError: list.remove(x): x not in list Version-Release number of selected component (if applicable): 0.0.190, HEAD How reproducible: Every time Steps to Reproduce: 1. Configure a repo with a blacklist filter. 2. Trigger a sync of that repo. Actual results: The sync fails with the error listed above. The full stack trace is: Traceback (most recent call last): File "/usr/lib/python2.4/site-packages/pulp/server/tasking/task.py", line 330, in run result = self.callable(*self.args, **self.kwargs) File "/usr/lib/python2.4/site-packages/pulp/server/api/repo_sync.py", line 224, in _sync progress_callback, synchronizer, max_speed, threads) File "/usr/lib/python2.4/site-packages/pulp/server/api/repo_sync.py", line 302, in fetch_content progress_callback, max_speed, threads) File "/usr/lib/python2.4/site-packages/pulp/server/api/synchronizers.py", line 747, in sync progress_callback) File "/usr/lib/python2.4/site-packages/pulp/server/api/synchronizers.py", line 607, in _sync_rpms pkglist = self._find_filtered_package_list(unfiltered_pkglist, whitelist_packages, blacklist_packages) File "/usr/lib/python2.4/site-packages/pulp/server/api/synchronizers.py", line 597, in _find_filtered_package_list pkglist.remove(pkg) ValueError: list.remove(x): x not in list Expected results: The sync proceeds apace with the selected packages filtered out. Additional info: Patch is attached.
Tested and applied patch.
build: 0.192
verified [root@preethi ~]# rpm -q pulp pulp-0.0.223-1.fc14.noarch [root@preethi ~]# [root@preethi ~]# pulp-admin repo clone --id=f14 --clone_id=f14-clone --clone_name=f14-clone --feed=parent -f filter1 -F Repository [f14] is being cloned as [f14-clone] Clone: Finished Item Details: Tree_Files: 6/6 Rpms: 2764/2766 [root@preethi ~]# pulp-admin repo clone --id=f14-clone -F Usage: pulp-admin <options> repo clone <options> pulp-admin: error: Option --clone_id is required; please see --help [root@preethi ~]# pulp-admin repo sync --id=f14-clone -F Sync for repository f14-clone started Sync: Finished 0/2772 new items downloaded 2772/2772 existing items processed Item Details: Tree_Files: 6/6 Rpms: 2764/2766
Closing with Community Release 15 pulp-0.0.223-4.